Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fields to store for organisation structured data for SEO #6113

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rahulsingh321
Copy link
Contributor

Summary

  • Added additional fields to store for the organisation data for SEO purpose.
  • Added address fields into store and validate state presence if country is present
  • Added specs

Screenshot

Screenshot from 2025-02-11 00-59-12

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@github-actions github-actions bot added changelog:solidus_api Changes to the solidus_api gem changelog:solidus_backend Changes to the solidus_backend gem labels Feb 10, 2025
@github-actions github-actions bot added the changelog:solidus_core Changes to the solidus_core gem label Feb 10, 2025
@rahulsingh321 rahulsingh321 changed the title Added fields to store for organisational structured data for SEO Added fields to store for organisation structured data for SEO Feb 10, 2025
@rahulsingh321 rahulsingh321 force-pushed the 5905-add-store-fields branch 5 times, most recently from 5221825 to 4d128b4 Compare February 17, 2025 19:35
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

Attention: Patch coverage is 9.67742% with 56 lines in your changes missing coverage. Please review.

Project coverage is 88.55%. Comparing base (8334e9c) to head (2b32fbd).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
.../components/solidus_admin/stores/show/component.rb 0.00% 42 Missing ⚠️
...nts/solidus_admin/stores/address_form/component.rb 0.00% 10 Missing ⚠️
...app/controllers/solidus_admin/stores_controller.rb 33.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6113      +/-   ##
==========================================
- Coverage   88.82%   88.55%   -0.28%     
==========================================
  Files         835      837       +2     
  Lines       18149    18210      +61     
==========================================
+ Hits        16121    16126       +5     
- Misses       2028     2084      +56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- Added new fields to spree_stores to support organization structured
data for SEO.
- Fields include legal_name, contact_email, contact_phone, description,
vat_id, tax_id, address1, address2, city, zipcode, state_name,
country_id, and state_id.
- This update enhances SEO by allowing structured data markup for better
search engine visibility.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_admin changelog:solidus_api Changes to the solidus_api gem changelog:solidus_backend Changes to the solidus_backend gem changelog:solidus_core Changes to the solidus_core gem changelog:solidus_sample Changes to the solidus_sample gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant