Skip to content

Fix SSL last run ID type#46

Merged
jcsco merged 1 commit into
v2from
agent/fix-ssl-last-run-id
Jul 9, 2026
Merged

Fix SSL last run ID type#46
jcsco merged 1 commit into
v2from
agent/fix-ssl-last-run-id

Conversation

@jcsco

@jcsco jcsco commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

Related to splunk/terraform-provider-synthetics#94


Before the change?

  • SslCheckV2Response.Test.LastRunId was modeled as an int.
  • The Synthetics API returns lastRunId as a UUID string, so decoding an SSL check response could fail with cannot unmarshal string into Go struct field ...lastRunId of type int.

After the change?

  • Model SSL check lastRunId values as strings.
  • Exercise a UUID lastRunId through GetSslCheckV2 and assert that the response preserves it exactly.

Pull request checklist

  • Regression test updated and the complete v2 unit test suite run
  • Docs reviewed; no documentation changes are needed

Test Output

go test ./syntheticsclientv2/... -v -tags=unit_tests -timeout=30s -parallel=4 -cover

PASS
coverage: 73.5% of statements
ok github.com/splunk/syntheticsclient/v2/syntheticsclientv2 1.351s

Additional validation:

go vet -tags=unit_tests ./syntheticsclientv2/...

Does this introduce a breaking change?

  • Yes
  • No

This changes the type of the exported LastRunId field from int to string. Code that assigns or compares an integer directly will need to use the API's UUID string representation instead.


@jcsco jcsco self-assigned this Jul 8, 2026
@jcsco jcsco mentioned this pull request Jul 8, 2026
4 tasks
@jcsco jcsco marked this pull request as ready for review July 8, 2026 16:07
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

CLA Assistant Lite bot CLA Assistant Lite bot All contributors have signed the COC ✍️ ✅

@jcsco

jcsco commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator Author

I have read the CLA Document and I hereby sign the CLA

@jcsco

jcsco commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator Author

I have read the Code of Conduct and I hereby accept the Terms

@etipton-splunk etipton-splunk left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

srv-gh-tools added a commit to splunk/cla-agreement that referenced this pull request Jul 9, 2026
@jcsco jcsco merged commit 5cc3244 into v2 Jul 9, 2026
4 of 16 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 9, 2026
@jcsco jcsco deleted the agent/fix-ssl-last-run-id branch July 9, 2026 15:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants