Skip to content

Fix SSL last run ID type #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcsco merged 1 commit into from
Jul 9, 2026
Merged

Fix SSL last run ID type #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion syntheticsclientv2/common_models.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -585,7 +585,7 @@ type SslCheckV2Response struct {
Lastrunat time.Time `json:"lastRunAt"`
LastRunCoreMetricsPublishedAt time.Time `json:"lastRunCoreMetricsPublishedAt"`
LastRunLocationId string `json:"lastRunLocationId"`
LastRunId int `json:"lastRunId"`
LastRunId string `json:"lastRunId"`
Automaticretries int `json:"automaticRetries"`
Createdby string `json:"createdBy"`
Updatedby string `json:"updatedBy"`
Expand Down
7 changes: 6 additions & 1 deletion syntheticsclientv2/get_sslcheckv2_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,10 @@ import (
"testing"
)

const getSslCheckV2LastRunID = "77ff08f0-3865-42d8-9fff-3efb7c25e176"

var (
getSslCheckV2Body = `{"test":{"id":1647,"type":"ssl","name":"ssl-check","frequency":5,"schedulingStrategy":"round_robin","active":true,"locationIds":["aws-us-east-1"],"createdAt":"2022-09-14T14:35:37.801Z","updatedAt":"2022-09-14T14:35:38.099Z","createdBy":"abc1234","updatedBy":"abc1234","customProperties":[{"key":"env","value":"prod"}],"automaticRetries":1,"lastRunStatus":"success","lastRunAt":"2024-03-07T00:47:43.741Z","lastRunCoreMetricsPublishedAt":"2024-03-07T00:47:43.741Z","lastRunLocationId":"aws-us-east-1","lastRunId":999,"host":"www.splunk.com","port":443,"serverName":"www.splunk.com","allowSelfSigned":true,"allowUntrustedRoot":false,"caCertificateId":42,"validations":[{"name":"Certificate expires later","type":"assert_numeric","actual":"{{certificate.days_until_expiration}}","expected":"30","comparator":"is_greater_than"}]}}`
getSslCheckV2Body = `{"test":{"id":1647,"type":"ssl","name":"ssl-check","frequency":5,"schedulingStrategy":"round_robin","active":true,"locationIds":["aws-us-east-1"],"createdAt":"2022-09-14T14:35:37.801Z","updatedAt":"2022-09-14T14:35:38.099Z","createdBy":"abc1234","updatedBy":"abc1234","customProperties":[{"key":"env","value":"prod"}],"automaticRetries":1,"lastRunStatus":"success","lastRunAt":"2024-03-07T00:47:43.741Z","lastRunCoreMetricsPublishedAt":"2024-03-07T00:47:43.741Z","lastRunLocationId":"aws-us-east-1","lastRunId":"` + getSslCheckV2LastRunID + `","host":"www.splunk.com","port":443,"serverName":"www.splunk.com","allowSelfSigned":true,"allowUntrustedRoot":false,"caCertificateId":42,"validations":[{"name":"Certificate expires later","type":"assert_numeric","actual":"{{certificate.days_until_expiration}}","expected":"30","comparator":"is_greater_than"}]}}`
inputGetSslCheckV2 = verifySslCheckV2Input(string(getSslCheckV2Body))
)

Expand All @@ -50,6 +52,9 @@ func TestGetSslCheckV2(t *testing.T) {
if !reflect.DeepEqual(resp.Test.ID, inputGetSslCheckV2.Test.ID) {
t.Errorf("returned \n\n%#v want \n\n%#v", resp.Test.ID, inputGetSslCheckV2.Test.ID)
}
if resp.Test.LastRunId != getSslCheckV2LastRunID {
t.Errorf("returned last run ID %q, want %q", resp.Test.LastRunId, getSslCheckV2LastRunID)
}
if !reflect.DeepEqual(resp.Test.Name, inputGetSslCheckV2.Test.Name) {
t.Errorf("returned \n\n%#v want \n\n%#v", resp.Test.Name, inputGetSslCheckV2.Test.Name)
}
Expand Down
Loading