Skip to content

Remove unnecessary reflection in RemoteChunkHandlerFactoryBean #4839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2025
Merged

Remove unnecessary reflection in RemoteChunkHandlerFactoryBean #4839

merged 1 commit into from
Jun 3, 2025

Conversation

scordio
Copy link
Contributor

@scordio scordio commented May 9, 2025 •
edited
Loading

Since #173, TaskletStep exposes getTasklet(), making reflection in RemoteChunkHandlerFactoryBean unnecessary.

In addition, the instanceof check can be simplified to a null check as the step field is already of type TaskletStep.

@scordio scordio mentioned this pull request May 28, 2025
Closed
@scordio scordio force-pushed the remove-reflection branch from ece48ff to ea35d45 Compare June 3, 2025 22:33
@fmbenhassine fmbenhassine added this to the 6.0.0-M1 milestone Jun 3, 2025
@fmbenhassine fmbenhassine added pr-for: enhancement in: integration for: backport-to-5.2.x Issues that will be back-ported to the 5.2.x line labels Jun 3, 2025
@fmbenhassine
Copy link
Contributor

This is great! Thank you for your contribution 👍

@fmbenhassine fmbenhassine merged commit 3f0857b into spring-projects:main Jun 3, 2025
1 of 2 checks passed
@scordio scordio deleted the remove-reflection branch June 3, 2025 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
for: backport-to-5.2.x Issues that will be back-ported to the 5.2.x line in: integration pr-for: enhancement
Projects
None yet
Milestone
6.0.0-M1
Development

Successfully merging this pull request may close these issues.
2 participants
@scordio @fmbenhassine