Skip to content

Implement UserDetailsPasswordService in JdbcUserDetailsManager #16863 #16881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Implement UserDetailsPasswordService in JdbcUserDetailsManager #16863 #16881

wants to merge 1 commit into from

Conversation

vasanth-79
Copy link
Contributor

@vasanth-79 vasanth-79 commented Apr 4, 2025 •
edited
Loading

Issue Number: #16863

  • Added UserDetailsPasswordService implementation to JdbcUserDetailsManager class.
  • Implemented updatePassword method to support password updates.

@vasanth-79
Implement UserDetailsPasswordService in JdbcUserDetailsManager
0529b82 
Issue Number: 16863

- Added UserDetailsPasswordService implementation to JdbcUserDetailsManager class.
- Implemented updatePassword method to support password updates.

Signed-off-by: Vasanth <[email protected]>
@vasanth-79 vasanth-79 mentioned this pull request Apr 4, 2025
Open
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 4, 2025
@rwinch rwinch self-assigned this Apr 8, 2025
@rwinch rwinch removed the status: waiting-for-triage An issue we've not yet triaged label Apr 8, 2025
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 8, 2025
rwinch
rwinch requested changes Apr 8, 2025
View reviewed changes
Copy link
Member

@rwinch rwinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I've provided feedback inline. A few more items:

  • Please fix the tests. You can run them using ./gradlew check
  • Please add more tests for this additional logic

core/src/main/java/org/springframework/security/provisioning/JdbcUserDetailsManager.java
@@ -64,7 +65,8 @@
* @author Luke Taylor
* @since 2.0
*/
public class JdbcUserDetailsManager extends JdbcDaoImpl implements UserDetailsManager, GroupManager {
public class JdbcUserDetailsManager extends JdbcDaoImpl
implements UserDetailsManager, GroupManager, UserDetailsPasswordService {

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a boolean property enableUpdatePassword which is false by default. The updatePassword method logic should only be ran if the property is true.

@rwinch rwinch added status: waiting-for-feedback We need additional information before we can continue in: core An issue in spring-security-core type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwinch rwinch rwinch requested changes

Assignees

@rwinch rwinch

Labels
in: core An issue in spring-security-core status: waiting-for-feedback We need additional information before we can continue type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vasanth-79 @rwinch @spring-projects-issues