Skip to content

Implement UserDetailsPasswordService in JdbcUserDetailsManager #16863 #16881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Implement UserDetailsPasswordService in JdbcUserDetailsManager #16863 #16881

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion core/src/main/java/org/springframework/security/provisioning/JdbcUserDetailsManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
import org.springframework.security.core.userdetails.User;
import org.springframework.security.core.userdetails.UserCache;
import org.springframework.security.core.userdetails.UserDetails;
import org.springframework.security.core.userdetails.UserDetailsPasswordService;
import org.springframework.security.core.userdetails.cache.NullUserCache;
import org.springframework.security.core.userdetails.jdbc.JdbcDaoImpl;
import org.springframework.util.Assert;
Expand All @@ -64,7 +65,8 @@
* @author Luke Taylor
* @since 2.0
*/
public class JdbcUserDetailsManager extends JdbcDaoImpl implements UserDetailsManager, GroupManager {
public class JdbcUserDetailsManager extends JdbcDaoImpl
implements UserDetailsManager, GroupManager, UserDetailsPasswordService {

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a boolean property enableUpdatePassword which is false by default. The updatePassword method logic should only be ran if the property is true.

public static final String DEF_CREATE_USER_SQL = "insert into users (username, password, enabled) values (?,?,?)";

Expand Down Expand Up @@ -598,4 +600,11 @@ private void validateAuthorities(Collection<? extends GrantedAuthority> authorit
}
}

@Override
public UserDetails updatePassword(UserDetails user, String newPassword) {
UserDetails updated = User.withUserDetails(user).password(newPassword).build();
updateUser(updated);
return updated;
}

}
Loading