Skip to content

chore(stackable-operator)!: Version common CRDs #968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 32 commits into
base: main
Choose a base branch
from
Open

chore(stackable-operator)!: Version common CRDs #968

wants to merge 32 commits into from

Conversation

Techassi
Copy link
Member

@Techassi Techassi commented Feb 26, 2025 •
edited
Loading

Part of stackabletech/issues#642

  • All CRD-related types and function now reside in the stackable_operator::crd module.
  • Each CRD-related struct and enum has been versioned. The initial version is v1alpha1.
  • The static authentication provider must now be imported using r#static.
  • Import are now more granular in general.

@Techassi Techassi self-assigned this Feb 26, 2025
@Techassi Techassi changed the title chore: Version common CRD structs chore(stackable-operator): Version common CRD structs Feb 26, 2025
This was referenced Feb 26, 2025
Open
Merged
@Techassi Techassi force-pushed the chore/add-crd-versioning branch from db324bf to fb6202e Compare March 19, 2025 14:43
@Techassi Techassi changed the title chore(stackable-operator): Version common CRD structs chore(stackable-operator)!: Version common CRDs Mar 20, 2025
@Techassi Techassi mentioned this pull request Mar 21, 2025
Merged
@Techassi Techassi moved this from Development: In Progress to Development: Waiting for Review in Stackable Engineering Mar 31, 2025
@Techassi Techassi marked this pull request as ready for review March 31, 2025 15:09
NickLarsenNZ
NickLarsenNZ previously approved these changes Apr 1, 2025
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left some suggestions.

@Techassi Techassi requested a review from NickLarsenNZ April 1, 2025 09:15
@NickLarsenNZ NickLarsenNZ moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Apr 2, 2025
NickLarsenNZ
NickLarsenNZ previously approved these changes Apr 2, 2025
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickLarsenNZ NickLarsenNZ self-requested a review April 2, 2025 11:09
NickLarsenNZ
NickLarsenNZ requested changes Apr 2, 2025
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more small change

@NickLarsenNZ NickLarsenNZ self-requested a review April 7, 2025 07:05
NickLarsenNZ
NickLarsenNZ previously approved these changes Apr 7, 2025
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy 😄

@Techassi Techassi requested a review from NickLarsenNZ April 7, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nightkr nightkr nightkr left review comments

@NickLarsenNZ NickLarsenNZ Awaiting requested review from NickLarsenNZ

At least 1 approving review is required to merge this pull request.

Assignees

@Techassi Techassi

Labels
None yet
Projects
Stackable Engineering
Status: Development: In Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Techassi @nightkr @NickLarsenNZ