Skip to content

feat(stackable-versioned): Add support for generics #969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 27, 2025

Conversation

Techassi
Copy link
Member

@Techassi Techassi commented Feb 26, 2025

Part of stackabletech/issues#642, came up in #968

This PR adds basic support for generic types in struct and enum definitions. More complex topics involving field actions are not covered by this. This (might) eventually come in follow-up PR.

@Techassi Techassi self-assigned this Feb 26, 2025
@Techassi Techassi force-pushed the feat/stackable-versioned-generic-type-support branch from 1754a01 to e219abd Compare February 27, 2025 12:54
@Techassi Techassi marked this pull request as ready for review February 27, 2025 13:12
@NickLarsenNZ NickLarsenNZ moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Feb 27, 2025
@NickLarsenNZ NickLarsenNZ self-requested a review February 27, 2025 13:49
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Techassi Techassi added this pull request to the merge queue Feb 27, 2025
@Techassi Techassi moved this from Development: In Review to Development: Done in Stackable Engineering Feb 27, 2025
Merged via the queue into main with commit 64f3736 Feb 27, 2025
10 checks passed
@Techassi Techassi deleted the feat/stackable-versioned-generic-type-support branch February 27, 2025 14:35
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants