-
Notifications
You must be signed in to change notification settings - Fork 90
fix(pinned/search popups): use short date format #19338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pinned/search popups): use short date format #19338
Conversation
- use `Locale.ShortFormat` in AppSearch and PinnedMessagesPopup - fixes message headers overflowing on mobile Fixes #19334
| required property string communityName | ||
| required property string communityColor | ||
| required property int type // Possible values [OwnershipState] | ||
| property bool showFullTimestamp: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unused
| onClicked: (sender) => root.senderNameClicked(sender) | ||
| onResendClicked: root.resendClicked() | ||
| timestamp: root.timestamp | ||
| showFullTimestamp: root.isInPinnedPopup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes the PinnedMessagesPopup
| searchResults: root.store.resultModel | ||
| formatTimestampFn: function (ts) { | ||
| return LocaleUtils.formatDateTime(parseInt(ts, 10)) | ||
| return LocaleUtils.formatDateTime(parseInt(ts, 10), Locale.ShortFormat) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes the AppSearch popup
Jenkins BuildsClick to see older builds (11)
|
micieslak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
What does the PR do
Locale.ShortFormatin AppSearch and PinnedMessagesPopupFixes #19334
BACKPORT_TO: 2.36
Affected areas
AppSearch and PinnedMessagesPopup
Architecture compliance
My PR is consistent with this document: QML Architecture Guidelines
Screencapture of the functionality
AppSearch:

PinnedMessagesPopup:

Impact on end user
Better UX on mobile