-
-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: address commit comments and use discrete uniform PRNG #5313
Conversation
Coverage Report
The above coverage report was generated for the changes in this PR. |
@rishavtarway Your PR titles still are not following our conventions. |
@kgryte sir i have followed the guidelines using refactor changes i have made to this commit |
@kgryte can you review it once now ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor changes. Thanks for fixing these areas!
lib/node_modules/@stdlib/stats/base/dists/binomial/median/benchmark/benchmark.native.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/binomial/median/benchmark/benchmark.native.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/binomial/median/benchmark/benchmark.native.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/binomial/median/benchmark/benchmark.native.js
Outdated
Show resolved
Hide resolved
…hmark/benchmark.native.js Co-authored-by: Karan Anand <[email protected]> Signed-off-by: Rishav Tarway <[email protected]>
…hmark/benchmark.native.js Co-authored-by: Karan Anand <[email protected]> Signed-off-by: Rishav Tarway <[email protected]>
…hmark/benchmark.native.js Co-authored-by: Karan Anand <[email protected]> Signed-off-by: Rishav Tarway <[email protected]>
…hmark/benchmark.native.js Co-authored-by: Karan Anand <[email protected]> Signed-off-by: Rishav Tarway <[email protected]>
@anandkaranubc hey can you review the suggested changes now ? |
Signed-off-by: Rishav Tarway <[email protected]>
Signed-off-by: Rishav Tarway <[email protected]>
Signed-off-by: Rishav Tarway <[email protected]>
lib/node_modules/@stdlib/stats/base/dists/binomial/median/benchmark/benchmark.native.js
Outdated
Show resolved
Hide resolved
…hmark/benchmark.native.js Co-authored-by: Karan Anand <[email protected]> Signed-off-by: Rishav Tarway <[email protected]>
@anandkaranubc i have updated the changes suggested |
@Planeshifter can you review this PR once ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good :)
PR Commit Message
Please review the above commit message and make any necessary adjustments. |
Resolves #5303.
Description
This pull request: address the commit comments of (commit 9b455b1
Related Issues
This pull request:
9b455b1
) #5303Questions
Hi, reviewers! Could you please check if I have followed the contributing guidelines properly? If there are any mistakes or areas for improvement in my code or approach, I would appreciate your feedback. I'm open to suggestions for making it better!
Other
No.
Checklist
@stdlib-js/reviewers