-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test Translator, JD and miner setup #1354
Test Translator, JD and miner setup #1354
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1354 +/- ##
=======================================
Coverage 17.89% 17.89%
=======================================
Files 132 132
Lines 10067 10067
=======================================
Hits 1801 1801
Misses 8266 8266
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
perhaps this is also suffering from the issues reported on #1420 |
aacf9ea
to
139b1f7
Compare
f3c51d2
to
abc644e
Compare
This is now unblocked after making this modification to the miner |
abc644e
to
f49b85b
Compare
a649827
to
a7c50cf
Compare
ca04a12
to
1b5a396
Compare
Addressed comments and rebased |
1b5a396
to
632719f
Compare
632719f
to
d533361
Compare
we're still removing |
90e1829
to
4f47257
Compare
.. Tests that when a miner submits shares to translator it is propagated up to the pool by JD.
4f47257
to
9be2893
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK but we need to fix CI
9be2893
to
844fd05
Compare
resolves #1353, #1474 and #1475
This is currently not working as expected. Same problem faced previously with #1207 where ghost processes are not exiting. Probably something need to be fixed at #1319/#1321