Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Translator, JD and miner setup #1354

Merged
merged 4 commits into from
Feb 28, 2025

Conversation

jbesraa
Copy link
Contributor

@jbesraa jbesraa commented Jan 16, 2025

resolves #1353, #1474 and #1475

This is currently not working as expected. Same problem faced previously with #1207 where ghost processes are not exiting. Probably something need to be fixed at #1319/#1321

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.89%. Comparing base (49cfdac) to head (844fd05).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1354   +/-   ##
=======================================
  Coverage   17.89%   17.89%           
=======================================
  Files         132      132           
  Lines       10067    10067           
=======================================
  Hits         1801     1801           
  Misses       8266     8266           
Flag Coverage Δ
binary_codec_sv2-coverage 0.00% <ø> (ø)
binary_sv2-coverage 6.96% <ø> (ø)
bip32_derivation-coverage 0.00% <ø> (ø)
buffer_sv2-coverage 37.68% <ø> (ø)
codec_sv2-coverage 0.02% <ø> (ø)
common_messages_sv2-coverage 0.17% <ø> (ø)
const_sv2-coverage 0.00% <ø> (ø)
error_handling-coverage 0.00% <ø> (ø)
framing_sv2-coverage 0.37% <ø> (ø)
jd_client-coverage 0.42% <ø> (ø)
jd_server-coverage 13.07% <ø> (ø)
job_declaration_sv2-coverage 0.00% <ø> (ø)
key-utils-coverage 3.61% <ø> (ø)
mining-coverage 3.17% <ø> (ø)
mining_device-coverage 0.00% <ø> (ø)
mining_proxy_sv2-coverage 0.82% <ø> (ø)
noise_sv2-coverage 5.79% <ø> (ø)
pool_sv2-coverage 2.47% <ø> (ø)
protocols 23.91% <ø> (ø)
roles 6.97% <ø> (ø)
roles_logic_sv2-coverage 11.59% <ø> (ø)
sv2_ffi-coverage 0.00% <ø> (ø)
template_distribution_sv2-coverage 0.00% <ø> (ø)
translator_sv2-coverage 9.58% <ø> (ø)
utils 36.39% <ø> (ø)
v1-coverage 3.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@plebhash
Copy link
Collaborator

perhaps this is also suffering from the issues reported on #1420

@jbesraa jbesraa force-pushed the 2025-01-16-translator-jd-test branch 4 times, most recently from aacf9ea to 139b1f7 Compare February 12, 2025 10:33
@jbesraa jbesraa marked this pull request as ready for review February 12, 2025 10:37
@jbesraa jbesraa force-pushed the 2025-01-16-translator-jd-test branch from f3c51d2 to abc644e Compare February 12, 2025 11:39
@jbesraa
Copy link
Contributor Author

jbesraa commented Feb 12, 2025

This is now unblocked after making this modification to the miner

@jbesraa jbesraa force-pushed the 2025-01-16-translator-jd-test branch from abc644e to f49b85b Compare February 13, 2025 08:45
@jbesraa jbesraa force-pushed the 2025-01-16-translator-jd-test branch 5 times, most recently from a649827 to a7c50cf Compare February 26, 2025 13:54
@jbesraa jbesraa force-pushed the 2025-01-16-translator-jd-test branch 3 times, most recently from ca04a12 to 1b5a396 Compare February 27, 2025 11:31
@jbesraa
Copy link
Contributor Author

jbesraa commented Feb 27, 2025

Addressed comments and rebased

@GitGab19
Copy link
Collaborator

@jbesraa you pointed this PR to issue #1476 in the description.

But #1476 is related to standard channels, and SV2 mining device.

This PR is not covering that, can you confirm? In case, update the PR description please

@jbesraa
Copy link
Contributor Author

jbesraa commented Feb 27, 2025

@jbesraa you pointed this PR to issue #1476 in the description.

But #1476 is related to standard channels, and SV2 mining device.

This PR is not covering that, can you confirm? In case, update the PR description please

Yea that's correct. Updated desc.

@jbesraa jbesraa force-pushed the 2025-01-16-translator-jd-test branch from 632719f to d533361 Compare February 27, 2025 15:05
@plebhash
Copy link
Collaborator

plebhash commented Feb 27, 2025

@jbesraa you pointed this PR to issue #1476 in the description.
But #1476 is related to standard channels, and SV2 mining device.
This PR is not covering that, can you confirm? In case, update the PR description please

Yea that's correct. Updated desc.

we're still removing pool-sri-test-1-standard on this PR, which should be updated too

This was referenced Feb 27, 2025
@jbesraa jbesraa force-pushed the 2025-01-16-translator-jd-test branch 3 times, most recently from 90e1829 to 4f47257 Compare February 28, 2025 10:41
.. Tests that when a miner submits shares to translator it is propagated
up to the pool by JD.
@jbesraa jbesraa force-pushed the 2025-01-16-translator-jd-test branch from 4f47257 to 9be2893 Compare February 28, 2025 12:00
Copy link
Collaborator

@plebhash plebhash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK but we need to fix CI

@jbesraa jbesraa force-pushed the 2025-01-16-translator-jd-test branch from 9be2893 to 844fd05 Compare February 28, 2025 17:11
@plebhash plebhash merged commit 6dde6b9 into stratum-mining:main Feb 28, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants