Skip to content

Conversation

bellini666
Copy link
Member

@bellini666 bellini666 commented Oct 12, 2025

Based on top of #4018

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @bellini666, your pull request is larger than the review limit of 150000 diff characters

@bellini666 bellini666 changed the title feat: drop support for Python 3.9 feat: update Optional/Union annotations to use the "|" syntax Oct 12, 2025
@bellini666 bellini666 marked this pull request as ready for review October 12, 2025 11:51
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @bellini666, your pull request is larger than the review limit of 150000 diff characters

@botberry
Copy link
Member

botberry commented Oct 12, 2025

Hi, thanks for contributing to Strawberry 🍓!

We noticed that this PR is missing a RELEASE.md file. We use that to automatically do releases here on GitHub and, most importantly, to PyPI!

So as soon as this PR is merged, a release will be made 🚀.

Here's an example of RELEASE.md:

Release type: patch

Description of the changes, ideally with some examples, if adding a new feature.

Release type can be one of patch, minor or major. We use semver, so make sure to pick the appropriate type. If in doubt feel free to ask :)

Here's the tweet text:

🆕 Release (next) is out! Thanks to @_bellini666 for the PR 👏

Get it here 👉 https://strawberry.rocks/release/(next)

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

@bellini666 bellini666 force-pushed the fix-ruff-py310 branch 3 times, most recently from bde0b0a to 76e2f54 Compare October 14, 2025 16:32
@botberry
Copy link
Member

botberry commented Oct 14, 2025

Apollo Federation Subgraph Compatibility Results

Federation 1 Support Federation 2 Support
_service🟢
@key (single)🟢
@key (multi)🟢
@key (composite)🟢
repeatable @key🟢
@requires🟢
@provides🟢
federated tracing🔲
@link🟢
@shareable🟢
@tag🟢
@override🟢
@inaccessible🟢
@composeDirective🟢
@interfaceObject🟢

Learn more:

Copy link

codecov bot commented Oct 14, 2025

Codecov Report

❌ Patch coverage is 97.48744% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.37%. Comparing base (513c7cc) to head (bcaadfd).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4019      +/-   ##
==========================================
- Coverage   94.41%   94.37%   -0.04%     
==========================================
  Files         532      532              
  Lines       34773    34736      -37     
  Branches     1828     1828              
==========================================
- Hits        32831    32783      -48     
- Misses       1647     1657      +10     
- Partials      295      296       +1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

codspeed-hq bot commented Oct 14, 2025

CodSpeed Performance Report

Merging #4019 will not alter performance

Comparing fix-ruff-py310 (bcaadfd) with main (513c7cc)

Summary

✅ 26 untouched

@bellini666 bellini666 force-pushed the fix-ruff-py310 branch 8 times, most recently from 197b17e to 0360b50 Compare October 18, 2025 13:52
@bellini666 bellini666 marked this pull request as ready for review October 18, 2025 14:12
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @bellini666, your pull request is larger than the review limit of 150000 diff characters

Copy link
Member

@patrick91 patrick91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:D

@patrick91 patrick91 merged commit 938f940 into main Oct 18, 2025
89 of 90 checks passed
@patrick91 patrick91 deleted the fix-ruff-py310 branch October 18, 2025 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants