Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOS-5986 Skip derivation errors #341

Merged
merged 3 commits into from
Mar 6, 2024
Merged

IOS-5986 Skip derivation errors #341

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2ffb346
IOS-5986 Skip derivation errors
tureck1y Mar 4, 2024
25e83ac
IOS-5986 Ignore only concrete errors
tureck1y Mar 5, 2024
a205aca
Merge branch 'develop' into IOS-5986_skip_derivation_errors
tureck1y Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions TangemSdk/TangemSdk/Operations/Derivation/DeriveWalletPublicKeysTask.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,14 +39,16 @@ public class DeriveWalletPublicKeysTask: CardSessionRunnable {
let path = derivationPaths[index]
let task = DeriveWalletPublicKeyTask(walletPublicKey: walletPublicKey, derivationPath: path)
task.run(in: session) { result in
var keys = keys

switch result {
case .success(let key):
var keys = keys
keys[path] = key
self.runDerivation(at: index + 1, keys: keys, in: session, completion: completion)
case .failure(let error):
completion(.failure(error))
Log.error(error)
}

self.runDerivation(at: index + 1, keys: keys, in: session, completion: completion)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Если так ничего падает то с богом

Copy link
Contributor

@skibinalexander skibinalexander Mar 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Если так ничего падает то с богом

А пардон, метод уже был, и работал ) просто за скоуп success улетел

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Да, я просто его перенес

}
}
}
Loading