Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOS-5986 Skip derivation errors #341

Merged
merged 3 commits into from
Mar 6, 2024
Merged

Conversation

tureck1y
Copy link
Collaborator

@tureck1y tureck1y commented Mar 4, 2024

Задача - игнорировать ошибки деривации отдельных ключей и не блокировать общий таск

@tureck1y tureck1y requested review from ba1ashov and megakoko March 4, 2024 17:19
@tureck1y tureck1y marked this pull request as ready for review March 4, 2024 17:19
@tureck1y tureck1y requested a review from a team as a code owner March 4, 2024 17:19
@tureck1y tureck1y requested review from skibinalexander and removed request for megakoko March 5, 2024 14:51
ba1ashov
ba1ashov previously approved these changes Mar 5, 2024
}

self.runDerivation(at: index + 1, keys: keys, in: session, completion: completion)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Если так ничего падает то с богом

Copy link
Contributor

@skibinalexander skibinalexander Mar 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Если так ничего падает то с богом

А пардон, метод уже был, и работал ) просто за скоуп success улетел

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Да, я просто его перенес

skibinalexander
skibinalexander previously approved these changes Mar 5, 2024
@tureck1y tureck1y dismissed stale reviews from skibinalexander and ba1ashov via 25e83ac March 5, 2024 18:14
@tureck1y
Copy link
Collaborator Author

tureck1y commented Mar 5, 2024

Все же добавил проверку именно на ошибки сдк. Чтобы в случае проблем с NFC, выкидывало сразу

@tureck1y tureck1y merged commit 68fcf88 into develop Mar 6, 2024
3 checks passed
@tureck1y tureck1y deleted the IOS-5986_skip_derivation_errors branch March 6, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants