Add image field type #47
Conversation
roidayan
force-pushed
the
add_image_field_type
branch
from
f76a5a3 to
20b9b57
Compare
roidayan
force-pushed
the
add_image_field_type
branch
from
20b9b57 to
47781d7
Compare
|
hi, any comments? |
|
Hi @tareq1988 any comments? |
|
Sorry for the long delay on reviewing this. Ideally I would like to store the attachment ID instead of image URL as we might need various sizes of that image and finding an attachment ID with URL will be a nightmare. So we could pass the attachment ID as a hidden field, a thumbnail version of the image preview (right now it shows the full size). Also limit the media manager to image-only selection, we certainly don't want to select a zip file as an image file. |
|
ok thanks for the comments. |
|
The point at first was to be able to supply external url as well. With your suggestions only the button and preview are needed (without the input box). the media manager has an upload tab to add external file into the media manager. |
|
another note. showing the original image was the point of showing the user the real preview of the size that is going to be used. i.e. i use it for adding image for email header and wanted the user to see preview of the image in real size. I guess this could be configurable of what kind of preview to show. |
|
Consider a raw image uploaded, or a fairly medium sized 1200x800, it would overflow the whole settings area. |
|
right, but in my example if i requested header email image then it can be considered a user mistake choosing image size that large. the default can be thumb if not specified. i'll split this into different commit later. |
roidayan
force-pushed
the
add_image_field_type
branch
4 times, most recently
from
6a0b1c7 to
6dad5a8
Compare
roidayan
force-pushed
the
add_image_field_type
branch
from
6dad5a8 to
c453b20
Compare
|
hi @tareq1988 , too bad this didn't get merged. I would like to revive this. we talked about user attaching raw img and code was updated to show thumbnail is exists. |
The image field type stores media id. The media manager is limited to type image. Settings section shows a thumbnail preview. Signed-off-by: Roi Dayan <[email protected]>
roidayan
force-pushed
the
add_image_field_type
branch
from
c453b20 to
00c2ea7
Compare
|
@roidayan and @tareq1988 just tested this code within my project and all in working, great. Thank @roidayan Definitely prefer the image field over the file, easier for my client to see what they have attached. If you need help maintaining the repo will be happy to help, I see there are a few pull requests outstanding. |
|
thanks. i'm still using this plugin as well. great thing. |
Works the same as file field type but with a preview of the image.
Signed-off-by: Roi Dayan [email protected]