Skip to content

fix: use string for maximum_backoff and minimum_backoff for pull subscriptions #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 10, 2025
Merged

fix: use string for maximum_backoff and minimum_backoff for pull subscriptions #229

merged 3 commits into from
Mar 10, 2025

Conversation

ktinubu
Copy link
Contributor

@ktinubu ktinubu commented Mar 10, 2025 •
edited by apeabody
Loading

Fixes: #227

@ktinubu ktinubu requested review from a team and imrannayer as code owners March 10, 2025 17:39
@ktinubu ktinubu changed the title fix!: use string for maximum_backoff and minimum_backoff for pull subsscriptions fix!: use string for maximum_backoff and minimum_backoff for pull subscriptions Mar 10, 2025
@ktinubu ktinubu requested a review from apeabody March 10, 2025 17:39
@ktinubu ktinubu mentioned this pull request Mar 10, 2025
Closed
@ktinubu ktinubu linked an issue Mar 10, 2025 that may be closed by this pull request
pull_subscriptions types for backoff should be string #227
Closed
@apeabody apeabody self-assigned this Mar 10, 2025
@apeabody
Copy link
Contributor

removing breaking change (!) as this is fixing the broken behavior

@apeabody apeabody changed the title fix!: use string for maximum_backoff and minimum_backoff for pull subscriptions fix: use string for maximum_backoff and minimum_backoff for pull subscriptions Mar 10, 2025
apeabody
apeabody approved these changes Mar 10, 2025
View reviewed changes
Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ktinubu!

@apeabody apeabody merged commit e4eea2a into terraform-google-modules:main Mar 10, 2025
4 checks passed
@release-please release-please bot mentioned this pull request Mar 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apeabody apeabody apeabody approved these changes

@imrannayer imrannayer Awaiting requested review from imrannayer imrannayer is a code owner

Assignees

@apeabody apeabody

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

pull_subscriptions types for backoff should be string

2 participants

@ktinubu @apeabody