fix: Add validation for instance template #510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amrkk123
requested review from
a team,
ayushmjain,
erlanderlo and
q2w
as code owners
q2w
approved these changes
Jul 30, 2025
modules/mig/metadata.display.yaml
Outdated
| name: instance_template | ||
| title: Instance Template | ||
| regexValidation: ^https:\/\/www\.googleapis\.com\/compute\/v1\/projects\/[a-z0-9](?:[-a-z0-9]{0,61}[a-z0-9])?\/(?:global|regions\/[a-z](?:[-a-z0-9]{0,61}[a-z0-9])?)\/instanceTemplates\/[a-z](?:[-a-z0-9]{0,61}[a-z0-9])?$ | ||
| validation: Invalid template url format, valid format is either https://www.googleapis.com/compute/v1/projects/PROJECT_ID/regions/REGION/instanceTemplates/TEMPLATE_NAME (regional) or https://www.googleapis.com/compute/v1/projects/PROJECT_ID/global/instanceTemplates/TEMPLATE_NAME (global). |
There was a problem hiding this comment.
nit: Let's use consistent placeholder for project, region etc. I sse {projectId} is for projectId. https://github.com/terraform-google-modules/terraform-google-sql-db/blob/main/modules/postgresql/metadata.display.yaml#L203
pawan1210
approved these changes
Jul 30, 2025
q2w
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.