Skip to content

fix: Add validation for instance template #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 31, 2025
Merged

fix: Add validation for instance template #510

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65c342f
Add validation for instance template
amrkk123 Jul 14, 2025
abe0014
Updating regex description
amrkk123 Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions modules/mig/metadata.display.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,8 @@ spec:
instance_template:
name: instance_template
title: Instance Template
regexValidation: ^https:\/\/www\.googleapis\.com\/compute\/v1\/projects\/[a-z0-9](?:[-a-z0-9]{0,61}[a-z0-9])?\/(?:global|regions\/[a-z](?:[-a-z0-9]{0,61}[a-z0-9])?)\/instanceTemplates\/[a-z](?:[-a-z0-9]{0,61}[a-z0-9])?$
validation: Invalid template url format, valid format is either https://www.googleapis.com/compute/v1/projects/PROJECT_ID/regions/REGION/instanceTemplates/TEMPLATE_NAME (regional) or https://www.googleapis.com/compute/v1/projects/PROJECT_ID/global/instanceTemplates/TEMPLATE_NAME (global).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Let's use consistent placeholder for project, region etc. I sse {projectId} is for projectId. https://github.com/terraform-google-modules/terraform-google-sql-db/blob/main/modules/postgresql/metadata.display.yaml#L203

labels:
name: labels
title: Labels
Expand Down