feat: support logs-agent resources configuration

[fidel-ibm]

Description

Allows configuration of resources for the logs-agent.

Git issue: #469

Release required?

• No release
• Patch release (x.x.X)
• Minor release (x.X.x)
• Major release (X.x.x)

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

• If relevant, a test for the change is included or updated with this PR.
• If relevant, documentation for the change is included or updated with this PR.

For mergers

• Use a conventional commit message to set the release level. Follow the guidelines.
• Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
• Use the Squash and merge option.

[ocofaigh]

Just 1 comment from me. @Aashiq-J as codeowner you any other concerns?

[shemau]

This looks good to me.

[shemau]

/run pipeline

[ocofaigh]

/run pipeline

[ocofaigh]

Oh the tests are blocked due to this issue: IBM-Cloud/terraform-provider-ibm#6036
There is supposed to be a provider release today with the fix, let me follow up on that

[ocofaigh]

Provider patch release coming today - will re-run after its released

[ocofaigh]

/run pipeline

[ocofaigh]

/run pipeline

[ocofaigh]

@fidel-ibm Your going to have to do some testing to get this to work. The tests failed with:

│ Error: failed parsing key "resources" with value {"limits":{"cpu":"500m","ephemeral_storage":"10Gi","memory":"3Gi"},"requests":{"cpu":"100m","ephemeral_storage":"2Gi","memory":"1Gi"}}, key "\"requests\":{\"cpu\":\"100m\"" has no value (cannot end with ,)
│ 
│   with module.observability_agents.module.logs_agent[0].helm_release.logs_agent,
│   on ../../modules/logs-agent/main.tf line 40, in resource "helm_release" "logs_agent":
│   40: resource "helm_release" "logs_agent" {
│ 
╵}

[ocofaigh]

maybe you need to use join("\\," like what was done in other sets for object types

[fidel-ibm]

hmm not sure what the issue is in this case, I cannot use join because that expect a list and we are passing an object.

I've moved this code to inside the values definition, to see if the yamlencode function handles the transformation well.

When I run terraform plan even with the previous setup, it had the proper output for the config.

[ocofaigh]

@fidel-ibm see comments

[ocofaigh]

/run pipeline

[ocofaigh]

/run pipeline

[ocofaigh]

@fidel-ibm Any joy locally testing this? The tests are failing with:

TestRunAgentVpcKubernetes 2025-03-13T10:37:31Z logger.go:67: │ Error: 1 error occurred:
TestRunAgentVpcKubernetes 2025-03-13T10:37:31Z logger.go:67: │ 	* DaemonSet.apps "logs-agent" is invalid: [spec.template.spec.containers[0].resources.limits[ephemeral_storage]: Invalid value: ephemeral_storage: must be a standard resource type or fully qualified, spec.template.spec.containers[0].resources.limits[ephemeral_storage]: Invalid value: ephemeral_storage: must be a standard resource for containers, spec.template.spec.containers[0].resources.requests[ephemeral_storage]: Invalid value: ephemeral_storage: must be a standard resource type or fully qualified, spec.template.spec.containers[0].resources.requests[ephemeral_storage]: Invalid value: ephemeral_storage: must be a standard resource for containers]

[jor2]

I see ephemeral_storage is included in the doc, but I can't see any evidence kubernetes supports ephemeral_storage as a standard resource type for containers.

[ocofaigh]

@jor2 I see you added support in terraform-ibm-modules/terraform-ibm-logs-agent#2 - Does it mean you got it working? Can you leave a comment in this PR as to what the issue is?

[jor2]

@jor2 I see you added support in terraform-ibm-modules/terraform-ibm-logs-agent#2 - Does it mean you got it working? Can you leave a comment in this PR as to what the issue is?

It works when you remove the field ephemeral_storage, doesn't seem like its a supported field yet IBM cloud docs suggests it is. I simply removed that field from other pr #470 (comment)