feat: move logs agents to its own tile #2

jor2 · 2025-03-13T13:27:35Z

Description

Release required?

No release
Patch release (x.x.X)
Minor release (x.X.x)
Major release (X.x.x)

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

If relevant, a test for the change is included or updated with this PR.
If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

ocofaigh

Left a few comments, but maybe this is still WIP as I notice the DA inputs still have cloud monitoring inputs there?

version.tf

variables.tf

tests/resources/existing-resources/main.tf

tests/README.md

solutions/fully-configurable/version.tf

tests/other_test.go

ocofaigh · 2025-03-20T10:54:02Z

@jor2 Can you add same codeowners as https://github.com/terraform-ibm-modules/terraform-ibm-observability-agents/blob/main/.github/CODEOWNERS

jor2 · 2025-03-20T19:38:07Z

/run pipeline

jor2 · 2025-03-21T13:37:34Z

/run pipeline

ocofaigh

See comments
The diagram should show some kind of flow of the agents sending data to a Cloud Logs instance.
Can we please use cross variable validation in the DA inputs

.github/settings.yml

.catalog-onboard-pipeline.yaml

ocofaigh · 2025-03-24T17:07:11Z

README.md

-Use real values instead of "var.<var_name>" or other placeholder values
-unless real values don't help users know what to change.
-->
+## Usage


Can you change back the readme so it aligns with the module template please

@jor2 This is still an open comment

ibm_catalog.json

solutions/fully-configurable/variables.tf

ocofaigh · 2025-03-24T17:16:53Z

solutions/fully-configurable/variables.tf

+}
+
+variable "logs_agent_additional_metadata" {
+  description = "The list of additional metadata fields to add to the routed logs."


This is a complex input so needs a corresponding markdown helper doc

still open comment

I did add this doc, maybe you missed https://github.com/terraform-ibm-modules/terraform-ibm-logs-agent/blob/b27c1e9501709c240267f0371fb67c95a26f3f77/solutions/fully-configurable/DA-types.md

tests/other_test.go

tests/resources/main.tf

ocofaigh · 2025-03-25T11:43:14Z

@jor2 Ca you see if you can add support for terraform-ibm-modules/terraform-ibm-observability-agents#470 in this PR too? I think the logic is slightly incorrect in that PR so you might need to fix it to get it working

jor2 · 2025-03-25T15:46:21Z

/run pipeline

jor2 · 2025-03-25T15:55:14Z

/run pipeline

ocofaigh

cloud logs icon is missing from diagram
You dont need to commit images/cloud-logs-icon.svg?
Can you add this to the renovate.json?

{
  "$schema": "https://docs.renovatebot.com/renovate-schema.json",
  "extends": ["github>terraform-ibm-modules/common-dev-assets:commonRenovateConfig"],
  "customManagers": [
    {
      "customType": "regex",
      "description": "Update agent version to the latest in variables.tf",
      "fileMatch": ["variables.tf$"],
      "datasourceTemplate": "docker",
      "matchStrings": [
        "default\\s*=\\s*\"(?<currentValue>.*)\"\\s*# datasource: (?<depName>[^\\s]+)"
      ]
    }
  ]
}

variables.tf

tests/resources/main.tf

tests/pr_test.go

ocofaigh · 2025-03-26T16:26:23Z

solutions/fully-configurable/variables.tf

+}
+
+variable "logs_agent_additional_metadata" {
+  description = "The list of additional metadata fields to add to the routed logs."


still open comment

solutions/fully-configurable/variables.tf

ibm_catalog.json

variables.tf

jor2 · 2025-04-01T16:22:34Z

/run pipeline

jor2 · 2025-04-01T20:06:26Z

/run pipeline

jor2 · 2025-04-02T13:00:16Z

/run pipeline

jor2 · 2025-04-02T15:31:33Z

/run pipeline

jor2 · 2025-04-03T12:41:15Z

error - known issue. https://ibm-cloudplatform.slack.com/archives/C02DYMP47EF/p1743596567371199?thread_ts=1743522645.890589&cid=C02DYMP47EF

TestFullyConfigurableSolution 2025-04-02T16:54:12Z logger.go:67: module.cloud_logs.ibm_resource_instance.cloud_logs: Still creating... [30s elapsed]
TestFullyConfigurableSolution 2025-04-02T16:54:16Z logger.go:67: ╷
Error: gurableSolution 2025-04-02T16:54:16Z logger.go:67: │ Error: [ERROR] Error waiting for create resource instance (crn:v1:bluemix:public:logs:au-syd:a/abac0df06b644a9cabc6e44f55b3880e:19f4bfb0-7ce6-4462-a642-52dae97ca0e0::) to be succeeded: [ERROR] The resource instance 'crn:v1:bluemix:public:logs:au-syd:a/abac0df06b644a9cabc6e44f55b3880e:19f4bfb0-7ce6-4462-a642-52dae97ca0e0::' create failed during async operation. error: <nil>
TestFullyConfigurableSolution 2025-04-02T16:54:16Z logger.go:67: │ last_operation_description: Provisioning operation for crn crn:v1:bluemix:public:logs:au-syd:a/abac0df06b644a9cabc6e44f55b3880e:19f4bfb0-7ce6-4462-a642-52dae97ca0e0:: has failed. Reason: Failed on precondition checking. Details: ValidationFailed Logs bucket is invalid
TestFullyConfigurableSolution 2025-04-02T16:54:16Z logger.go:67: │ 
TestFullyConfigurableSolution 2025-04-02T16:54:16Z logger.go:67: │   with module.cloud_logs.ibm_resource_instance.cloud_logs,
TestFullyConfigurableSolution 2025-04-02T16:54:16Z logger.go:67: │   on .terraform/modules/cloud_logs/main.tf line 7, in resource "ibm_resource_instance" "cloud_logs":
TestFullyConfigurableSolution 2025-04-02T16:54:16Z logger.go:67: │    7: resource "ibm_resource_instance" "cloud_logs" {
TestFullyConfigurableSolution 2025-04-02T16:54:16Z logger.go:67: │ 
TestFullyConfigurableSolution 2025-04-02T16:54:16Z logger.go:67: │ ---
TestFullyConfigurableSolution 2025-04-02T16:54:16Z logger.go:67: │ id: terraform-446cc00a
TestFullyConfigurableSolution 2025-04-02T16:54:16Z logger.go:67: │ summary: |-
Error: lyConfigurableSolution 2025-04-02T16:54:16Z logger.go:67: │   [ERROR] Error waiting for create resource instance (crn:v1:bluemix:public:logs:au-syd:a/abac0df06b644a9cabc6e44f55b3880e:19f4bfb0-7ce6-4462-a642-52dae97ca0e0::) to be succeeded: [ERROR] The resource instance 'crn:v1:bluemix:public:logs:au-syd:a/abac0df06b644a9cabc6e44f55b3880e:19f4bfb0-7ce6-4462-a642-52dae97ca0e0::' create failed during async operation. error: <nil>
TestFullyConfigurableSolution 2025-04-02T16:54:16Z logger.go:67: │   last_operation_description: Provisioning operation for crn crn:v1:bluemix:public:logs:au-syd:a/abac0df06b644a9cabc6e44f55b3880e:19f4bfb0-7ce6-4462-a642-52dae97ca0e0:: has failed. Reason: Failed on precondition checking. Details: ValidationFailed Logs bucket is invalid
TestFullyConfigurableSolution 2025-04-02T16:54:16Z logger.go:67: │ severity: error
TestFullyConfigurableSolution 2025-04-02T16:54:16Z logger.go:67: │ resource: ibm_resource_instance
TestFullyConfigurableSolution 2025-04-02T16:54:16Z logger.go:67: │ operation: create
TestFullyConfigurableSolution 2025-04-02T16:54:16Z logger.go:67: │ component:
TestFullyConfigurableSolution 2025-04-02T16:54:16Z logger.go:67: │   name: github.com/IBM-Cloud/terraform-provider-ibm
TestFullyConfigurableSolution 2025-04-02T16:54:16Z logger.go:67: │   version: 1.76.3
TestFullyConfigurableSolution 2025-04-02T16:54:16Z logger.go:67: │ ---

jor2 · 2025-04-07T19:43:12Z

/run pipeline

ocofaigh

@jor2 see comments

.github/settings.yml

ocofaigh · 2025-04-09T11:21:36Z

README.md

-Use real values instead of "var.<var_name>" or other placeholder values
-unless real values don't help users know what to change.
-->
+## Usage


@jor2 This is still an open comment

ibm_catalog.json

main.tf

variables.tf

.catalog-onboard-pipeline.yaml

ocofaigh

@jor2 The chart and image versions need to be separate inputs. So we should have:

logs_agent_image
logs_agent_image_version
logs_agent_chart
logs_agent_chart_location
logs_agent_chart_version

ocofaigh

see comments

tests/scripts/pre-validation-deploy-slz-roks-and-logs-instances.sh

tests/resources/main.tf

solutions/fully-configurable/variables.tf

ibm_catalog.json

jor2 self-assigned this Mar 13, 2025

jor2 requested review from ocofaigh and daniel-butler-irl as code owners March 13, 2025 13:27

jor2 changed the title ~~feat: Move Observability agents to its own tile~~ feat: Move logs agents to its own tile Mar 18, 2025

ocofaigh requested changes Mar 18, 2025

View reviewed changes

jor2 marked this pull request as draft March 19, 2025 02:28

jor2 marked this pull request as ready for review March 19, 2025 14:12

jor2 force-pushed the agent-da branch 2 times, most recently from a43364d to 9a924ef Compare March 19, 2025 16:46

jor2 force-pushed the agent-da branch 2 times, most recently from 62b2320 to c93af1d Compare March 20, 2025 19:38

jor2 requested review from ocofaigh, shemau and Aashiq-J and removed request for daniel-butler-irl March 21, 2025 16:11

jor2 changed the title ~~feat: Move logs agents to its own tile~~ feat: move logs agents to its own tile Mar 21, 2025

ocofaigh requested changes Mar 24, 2025

View reviewed changes

jor2 mentioned this pull request Mar 24, 2025

feat: initial module + DA terraform-ibm-modules/terraform-ibm-monitoring-agent#7

Merged

6 tasks

ocofaigh mentioned this pull request Mar 26, 2025

feat: support logs-agent resources configuration terraform-ibm-modules/terraform-ibm-observability-agents#470

Open

6 tasks

ocofaigh requested changes Mar 26, 2025

View reviewed changes

jor2 force-pushed the agent-da branch from 4b888dc to d6aacb6 Compare April 2, 2025 12:57

feat: move logs agents to its own tile

b6db4f2

fix: catalog.json SKIP UPGRADE TESTS

0371c6c

jor2 requested a review from ocofaigh April 2, 2025 16:24

Merge branch 'main' into agent-da

d6b558c

Jordan-Williams2 added 3 commits April 7, 2025 20:25

fix: merge conflicts

f5aa84b

fix: update code

31df561

fix: update code

294ab94

ocofaigh requested changes Apr 9, 2025

View reviewed changes

Jordan-Williams2 added 2 commits April 9, 2025 13:49

fix: address feedback

9e9bbec

fix: address feedback

99f6118

ocofaigh requested changes Apr 9, 2025

View reviewed changes

jor2 and others added 10 commits April 14, 2025 22:32

Merge branch 'main' into agent-da

04eebf3

fix: address feedback

cfe48a4

Merge branch 'main' into agent-da

5dbe4f3

Merge branch 'main' into agent-da

7962834

fix: making in-line with monitoring repo

9cdb0eb

fix: making in-line with monitoring repo

0068224

fix: required

c5dd363

fix: required

1e5ffc8

fix: update ibm catalog

b36dd50

fix: update permissions

69af5fd

ocofaigh requested changes Apr 29, 2025

View reviewed changes

jor2 and others added 5 commits April 29, 2025 13:05

Merge branch 'main' into agent-da

8e58620

Merge branch 'main' into agent-da

7647573

fix: update code

59b615f

fix: update code

8b5bb94

fix: update code

db1a403

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: move logs agents to its own tile #2

feat: move logs agents to its own tile #2

jor2 commented Mar 13, 2025

ocofaigh left a comment

ocofaigh commented Mar 20, 2025

jor2 commented Mar 20, 2025

jor2 commented Mar 21, 2025

ocofaigh left a comment

ocofaigh Mar 24, 2025

ocofaigh Apr 9, 2025

ocofaigh Mar 24, 2025

ocofaigh Mar 26, 2025

jor2 Mar 26, 2025

ocofaigh commented Mar 25, 2025

jor2 commented Mar 25, 2025

jor2 commented Mar 25, 2025

ocofaigh left a comment

ocofaigh Mar 26, 2025

jor2 commented Apr 1, 2025

jor2 commented Apr 1, 2025

jor2 commented Apr 2, 2025

jor2 commented Apr 2, 2025

jor2 commented Apr 3, 2025 •

edited

Loading

jor2 commented Apr 7, 2025

ocofaigh left a comment

ocofaigh Apr 9, 2025

ocofaigh left a comment

ocofaigh left a comment

feat: move logs agents to its own tile #2

Are you sure you want to change the base?

feat: move logs agents to its own tile #2

Conversation

jor2 commented Mar 13, 2025

Description

Release required?

Release notes content

Run the pipeline

Checklist for reviewers

For mergers

ocofaigh left a comment

Choose a reason for hiding this comment

ocofaigh commented Mar 20, 2025

jor2 commented Mar 20, 2025

jor2 commented Mar 21, 2025

ocofaigh left a comment

Choose a reason for hiding this comment

ocofaigh Mar 24, 2025

Choose a reason for hiding this comment

ocofaigh Apr 9, 2025

Choose a reason for hiding this comment

ocofaigh Mar 24, 2025

Choose a reason for hiding this comment

ocofaigh Mar 26, 2025

Choose a reason for hiding this comment

jor2 Mar 26, 2025

Choose a reason for hiding this comment

ocofaigh commented Mar 25, 2025

jor2 commented Mar 25, 2025

jor2 commented Mar 25, 2025

ocofaigh left a comment

Choose a reason for hiding this comment

ocofaigh Mar 26, 2025

Choose a reason for hiding this comment

jor2 commented Apr 1, 2025

jor2 commented Apr 1, 2025

jor2 commented Apr 2, 2025

jor2 commented Apr 2, 2025

jor2 commented Apr 3, 2025 • edited Loading

jor2 commented Apr 7, 2025

ocofaigh left a comment

Choose a reason for hiding this comment

ocofaigh Apr 9, 2025

Choose a reason for hiding this comment

ocofaigh left a comment

Choose a reason for hiding this comment

ocofaigh left a comment

Choose a reason for hiding this comment

jor2 commented Apr 3, 2025 •

edited

Loading