Skip to content

feat(ci): add shared parallel PR review workflow - #4

Merged
zrosenbauer merged 4 commits into
mainfrom
feat/parallel-pr-reviews
Nov 3, 2026
Merged

zrosenbauer merged 4 commits into
mainfrom
feat/parallel-pr-reviews

Conversation

@zrosenbauer

@zrosenbauer zrosenbauer commented Oct 30, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Central reusable PR-review engine: four parallel specialists, cheaper synthesis, deterministic Approve / Request changes / Incomplete verdict.
  • Per-repo trusted-base .github/pull.yaml for specialist instructions, model overrides, and shorter timeouts.
  • Pinned manual callers prepared for all seven currently public repositories. Private repos remain untouched.

Motivation

Consistent, bounded PR reviews without duplicating runtime or granting the PR head control over workflow/configuration.

Key Changes

  • .github/workflows/pull-review.yml: preparation, specialist matrix, synthesis, and optional publication.
  • .github/workflows/pr-review.yml: this repository's manual caller, pinned to engine commit e1ba85a421032865ae326526880a997c78cd4576.
  • review/prepare.mts, review/finish.mts: two runtime scripts; no custom CLI framework, schema validator, policy crawler, Ruby parser, or static model registry.
  • Correct synthesis startup to use the Git checkout, with an explicit relative report path and regression test.
  • review/README.md: installation, configuration, working-directory contract, safety limits, and links to every caller PR.

Testing

  • Seven tests pass, including the real collection CLI and Git startup/report-path regression.
  • Strict tsgo, Oxlint, Oxfmt, Actionlint, and whitespace checks pass.
  • All seven callers checked for matching pins, manual-only triggers, opt-in publication, and named-secret forwarding.
  • Caller Actionlint/format checks pass. App validation passes for almanac/farmall (cached Turbo tasks); remaining repos have local dependency/toolchain blockers documented in their PRs.
  • No live inference, manual workflow dispatch, or publication run.

Notes

Not activated: all changes remain in PRs, with manual-only callers and publication off by default. Automatic PR triggers, branch protection, org secrets, and Pullfrog service settings have not been changed.

Activation blockers: Pullfrog agents still expose GitHub mutation tools despite disabled shell/push. publish: false disables our publisher, not every possible agent-side side effect. Resolve the enforced tool boundary or explicitly choose an accepted deployment restriction before enabling public-PR automation. Pullfrog installation/BYOK and org-secret availability remain unverified; org-secret listing returned HTTP 403 with the current token.

The action SHA pins its bootstrap, but that bootstrap resolves an npm runtime range; runtime behavior is not fully immutable. Verdict-specific instruction overrides are not wired yet (verdict model selection is supported).

Public repository wiring

zrosenbauer and others added 3 commits October 30, 2026 00:27
Add role-specific Pullfrog reviews, Synthetic model configuration, bounded execution, and deterministic approval safeguards. Keep callers and publication opt-in pending a security review and live pilot.

Co-Authored-By: Claude <noreply@anthropic.com>
Remove the custom schema validator, policy crawler, Ruby parser, model registry, and CLI framework. Use the runner's yq and Pullfrog's output validation, retaining only preparation and finalization scripts with focused safeguard tests.

Co-Authored-By: Claude <noreply@anthropic.com>
Correct the synthesis report path, exercise collection and Git startup in a regression test, and document the working-directory contract. Use Pull review naming for callers and installation guidance.

Co-Authored-By: Claude <noreply@anthropic.com>
Add this repository's pinned manual caller and document installation PRs for every public repository. Keep callers separate from the reusable workflow and leave automatic triggers and secret settings unchanged.

Co-Authored-By: Claude <noreply@anthropic.com>
@zrosenbauer
zrosenbauer marked this pull request as ready for review November 3, 2026 01:32
@zrosenbauer
zrosenbauer merged commit 2070350 into main Nov 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant