Skip to content

ci: wire centralized parallel PR review - #208

Merged
zrosenbauer merged 1 commit into
mainfrom
ci/parallel-pr-review
Nov 3, 2026
Merged

zrosenbauer merged 1 commit into
mainfrom
ci/parallel-pr-review

Conversation

@zrosenbauer

Copy link
Copy Markdown
Member

Summary

  • Add a manual Pull review caller at .github/workflows/pr-review.yml.
  • Pin the reusable workflow and engine checkout to e1ba85a421032865ae326526880a997c78cd4576.
  • Inherit central specialist prompts, defaults, and optional base-branch .github/pull.yaml configuration.

Changes

Calls the centralized parallel review engine from thebytefarm/.github#4. No duplicated runtime, automatic PR triggers, branch protection changes, or changeset needed for this CI-only change.

Testing

Actionlint, workflow formatting, and whitespace checks pass. pnpm validate was attempted but blocked by missing worktree dependencies (rslib, tsgo, knip).

Notes

Manual dispatch only; publication defaults off. This does not activate automatic PR reviews. Requires Pullfrog installation/BYOK and access to SYNTHETIC_API_KEY; org-secret access could not be verified with the current GitHub token.

Pullfrog agents still expose GitHub mutation tools despite disabled shell/push. publish: false disables the central publisher, not every possible agent-side mutation. No live inference or publication was run. Resolve that tool-permission boundary before enabling arbitrary public-PR automation. Existing Pullfrog workflows and service settings are unchanged.

Add a manual caller pinned to the shared review engine. Keep automatic triggers disabled and publication opt-in while the worker tool boundary is unresolved.

Co-Authored-By: Claude <noreply@anthropic.com>
@vercel

vercel Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
ciderpress Ready Ready Preview Nov 3, 2026 1:33am UTC

@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Walkthrough

The new manually dispatched workflow requires a PR number and provides an optional publish input that defaults to false. It calls a pinned shared workflow, passes both inputs and SYNTHETIC_API_KEY, and sets workflow-level and job-level permissions.

Estimated code review effort: 2 (Simple) | ~8 minutes

Merge Risk: Low · up to d092f

The new manual review workflow is off by default and needs a maintainer to dispatch it. The author notes that the reviewing agents may still hold GitHub mutation tools even with publishing disabled. Confirm the Pullfrog tool restrictions before running it on untrusted or public PRs.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title "ci: wire centralized parallel PR review" names the main change: a manual PR review caller workflow that connects to the centralized parallel review engine. It matches the raw summary, the o…
Description check Passed The description covers the added manual review caller at .github/workflows/pr-review.yml, the pinned reusable workflow and engine commit, the manual-dispatch-only design with publication off by defaul…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "ci: wire centralized parallel PR review" names the main change: a manual PR review caller workflow that connects to the centralized parallel review engine. It matches the raw summary, the objectives, and the description. It is short and specific.

Full details: Description check

Explanation

The description covers the added manual review caller at .github/workflows/pr-review.yml, the pinned reusable workflow and engine commit, the manual-dispatch-only design with publication off by default, testing results, and open tool-permission concerns. It is directly related to the changeset.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

ast-grep (0.51.1)

ast-grep could not parse rule config: /ast-grep-rules/ast-grep-essentials/rules/rust/security/hardcoded-password-rust.yml

Tip

🎯 Customize your risk assessments

Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.

✅ Automatic approvals, with your rules

Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.
Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 88b7b8a and d092fec.

Files selected for processing: 1
  • .github/workflows/pr-review.yml

Included review availability: This review used your included allowance. 3 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes: Reviewed the complete manual-review caller and verified its inputs, permissions, and credential flow against the pinned centralized workflow.

  • Manual Dispatch: Adds a required PR number and optional publication flag, defaulting to artifact-only publication behavior, without enabling automatic PR triggers or changing existing automation.
  • Pinned Engine: Uses the same reviewed central commit for the reusable workflow and engine checkout, matching the engine's documented caller contract.
  • Authorization: Explicitly forwards SYNTHETIC_API_KEY and grants the read/OIDC permissions required by the engine; publication uses a separately minted Pullfrog installation token rather than write permissions on GITHUB_TOKEN.
  • Validation And Limits: pnpm check and targeted workflow formatting checks passed; actionlint was unavailable locally. No live inference or publication was run, and secret access and installation permissions remain unverified. The documented agent-side mutation-tool limitation still applies even when publish is false.

Pullfrog  | View workflow run | Using gpt-6.1-sol | 𝕏

@zrosenbauer
zrosenbauer enabled auto-merge (squash) November 3, 2026 01:36
@argos-ci

argos-ci Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ⚠️ Changes detected (Review) 3 changed Nov 3, 2026, 1:38 AM

@zrosenbauer
zrosenbauer merged commit 87231b7 into main Nov 3, 2026
8 of 9 checks passed
@zrosenbauer
zrosenbauer deleted the ci/parallel-pr-review branch November 3, 2026 01:38

This branch was successfully deployed

1 active deployment
Preview — d092fec9 Deployed Nov 3, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant