Skip to content

Add session properties configuration #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sudohainguyen
Copy link

The MR is about to support passing file-based session property config and mount to config path which is default by /etc/trino

Copy link

cla-bot bot commented May 12, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@sudohainguyen sudohainguyen force-pushed the add-session-property branch from 00e0d97 to 9de3d47 Compare May 12, 2025 15:08
Copy link

cla-bot bot commented May 12, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@sudohainguyen sudohainguyen force-pushed the add-session-property branch from 9de3d47 to 6b5e665 Compare May 12, 2025 16:12
Copy link

cla-bot bot commented May 12, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@sudohainguyen
Copy link
Author

hi @nineinchnick is there any. blockers?

@nineinchnick nineinchnick added the enhancement New feature or request label May 18, 2025
@nineinchnick
Copy link
Member

No, except for the signed CLA. They're processed every 2-3 weeks, and I'd expect the next batch to be processed in a few days.

@sudohainguyen sudohainguyen force-pushed the add-session-property branch from 6b5e665 to 1e7113a Compare May 20, 2025 01:43
Copy link

cla-bot bot commented May 20, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@sudohainguyen sudohainguyen force-pushed the add-session-property branch from 1e7113a to 43a44d3 Compare May 20, 2025 13:08
Copy link

cla-bot bot commented May 20, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@sudohainguyen sudohainguyen force-pushed the add-session-property branch from 43a44d3 to 9d3984f Compare May 20, 2025 13:46
Copy link

cla-bot bot commented May 20, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@sudohainguyen sudohainguyen force-pushed the add-session-property branch 2 times, most recently from d3a875d to 8ac7c68 Compare May 20, 2025 14:23
Copy link

cla-bot bot commented May 20, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@nineinchnick
Copy link
Member

@sudohainguyen you know you can run tests locally, right? :-)

@sudohainguyen
Copy link
Author

@nineinchnick my bad, been trying to run test script in local but got this

./test.sh: line 5: default: unbound variable

@nineinchnick
Copy link
Member

Which version of bash do you use? If you have 3.x, try upgrading to 5.x. Bash 3 is 21 years old.

@sudohainguyen
Copy link
Author

ah right, that's it! let me try

@sudohainguyen
Copy link
Author

sudohainguyen commented May 20, 2025

cannot upgrade directly in my mac, any other ways?
good now, running test

@sudohainguyen sudohainguyen force-pushed the add-session-property branch from 8ac7c68 to 432505b Compare May 20, 2025 15:33
@sudohainguyen
Copy link
Author

passed in local with the change but got pod trino-g3ayjhc6cq-trino-test-networkpolicy failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants