Add session properties configuration #348
Conversation
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
sudohainguyen
force-pushed
the
add-session-property
branch
from
00e0d97 to
9de3d47
Compare
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
sudohainguyen
force-pushed
the
add-session-property
branch
from
9de3d47 to
6b5e665
Compare
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
hi @nineinchnick is there any. blockers? |
|
No, except for the signed CLA. They're processed every 2-3 weeks, and I'd expect the next batch to be processed in a few days. |
sudohainguyen
force-pushed
the
add-session-property
branch
from
6b5e665 to
1e7113a
Compare
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
sudohainguyen
force-pushed
the
add-session-property
branch
from
1e7113a to
43a44d3
Compare
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
sudohainguyen
force-pushed
the
add-session-property
branch
from
43a44d3 to
9d3984f
Compare
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
sudohainguyen
force-pushed
the
add-session-property
branch
2 times, most recently
from
d3a875d to
8ac7c68
Compare
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
@sudohainguyen you know you can run tests locally, right? :-) |
|
@nineinchnick my bad, been trying to run test script in local but got this |
|
Which version of bash do you use? If you have 3.x, try upgrading to 5.x. Bash 3 is 21 years old. |
|
ah right, that's it! let me try |
|
|
Signed-off-by: Harry <[email protected]>
sudohainguyen
force-pushed
the
add-session-property
branch
from
8ac7c68 to
432505b
Compare
|
passed in local with the change but got |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
| @@ -117,6 +117,15 @@ data: | |||
| {{- end }} | |||
| {{- end }} | |||
|
|
|||
| {{- if .Values.sessionProperties }} | |||
| session-property-config.properties: | | |||
| session-property-config.configuration-manager=file | |||
There was a problem hiding this comment.
I was just reviewing this again, as I was just about to merge it, and I realized this is limiting if someone would like to use a custom session properties manager. Can you model this in the same way how resource groups are defined? They also allow specifying a JSON configuration, but there's a fallback to a list of properties.
The MR is about to support passing file-based session property config and mount to config path which is default by
/etc/trino