Improve test suite: remove redundancy, add table-driven tests, fill coverage gaps - #46
Merged
Conversation
…overage gaps - Remove redundant tests superseded by table-driven equivalents (staticdisplay individual type tests, JaroWinklerKnownValues, SubcommandsHaveActions, ShowJSON_WritesToFile) - Convert 5 test groups to table-driven: formatResult types, flagOptions, missing-required-flag errors, iterator formats, hidden subcommands - Tighten weak assertions (countTerminalLines exact values, ShowJSON_Transform vacuous NotContains replaced with exact Equal) - Fix WithTransform iterator test to actually exercise the transform code path - Add new tests: no-close-match suggest, createDownloadFile (Content-Disposition, MIME fallback, directory traversal), tenant CRUD integration test - Un-skip 26 auto-generated mock server tests (graceful skip via mocktest helper) - Add unit tests for stdin piping, error paths, command structure, format functions, iterator output, and explorer/static display rendering
xehl
added a commit
that referenced
this pull request
Mar 12, 2026
These test files from PR #46 reference old function signatures that changed in the Stainless regeneration. They'll be re-added once updated to match the new generated code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JaroWinklerKnownValues,SubcommandsHaveActions,ShowJSON_WritesToFile, duplicate iterator transform test)formatResulttypes,flagOptionsvariants, missing-required-flag errors, iterator format outputs, and hidden subcommandscountTerminalLinesnow uses exact expected values instead ofGreaterOrEqual; vacuousNotContainsinShowJSON_Transformreplaced with exactEqualcreateDownloadFile(Content-Disposition, MIME fallback, directory traversal sanitization), no-close-match suggest, tenant CRUD integration testmocktesthelper to gracefully skip when the mock server is unreachable instead of hard-failingCOURIER_API_KEY