Improve test suite: remove redundancy, add table-driven tests, fill coverage gaps

cmd/courier/main_test.go

@@ -0,0 +1,68 @@
+package main
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+	"github.com/trycourier/courier-cli/pkg/cmd"
+	"github.com/urfave/cli/v3"
+)
+
+func TestPrepareForAutocomplete(t *testing.T) {
+	t.Parallel()
+
+	root := &cli.Command{
+		Name: "test",
+		Commands: []*cli.Command{
+			{
+				Name: "child1",
+				Commands: []*cli.Command{
+					{Name: "grandchild1"},
+				},
+			},
+			{Name: "child2"},
+		},
+	}
+
+	assert.False(t, root.SkipFlagParsing)
+	assert.False(t, root.Commands[0].SkipFlagParsing)
+	assert.False(t, root.Commands[0].Commands[0].SkipFlagParsing)
+	assert.False(t, root.Commands[1].SkipFlagParsing)
+
+	prepareForAutocomplete(root)
+
+	assert.True(t, root.SkipFlagParsing, "root should have SkipFlagParsing set")
+	assert.True(t, root.Commands[0].SkipFlagParsing, "child1 should have SkipFlagParsing set")
+	assert.True(t, root.Commands[0].Commands[0].SkipFlagParsing, "grandchild1 should have SkipFlagParsing set")
+	assert.True(t, root.Commands[1].SkipFlagParsing, "child2 should have SkipFlagParsing set")
+}
+
+func TestPrepareForAutocomplete_EmptyCommand(t *testing.T) {
+	t.Parallel()
+
+	root := &cli.Command{Name: "empty"}
+	prepareForAutocomplete(root)
+	assert.True(t, root.SkipFlagParsing)
+}
+
+func TestCommandErrorBuffer(t *testing.T) {
+	t.Parallel()
+
+	// Verify the CommandErrorBuffer exists and is usable
+	cmd.CommandErrorBuffer.Reset()
+	assert.Equal(t, 0, cmd.CommandErrorBuffer.Len())
+
+	cmd.CommandErrorBuffer.WriteString("test error")
+	assert.Equal(t, "test error", cmd.CommandErrorBuffer.String())
+	cmd.CommandErrorBuffer.Reset()
+}
+
+func TestAppCommandIsInitialized(t *testing.T) {
+	t.Parallel()
+
+	app := cmd.Command
+	assert.NotNil(t, app)
+	assert.Equal(t, "courier", app.Name)
+	assert.NotEmpty(t, app.Version)
+	assert.NotEmpty(t, app.Commands)
+}

internal/autocomplete/autocomplete_test.go

@@ -391,3 +391,58 @@ func TestGetCompletions_AllFlagsWhenNoPrefix(t *testing.T) {
 	// Should show all flag variations
 	assert.GreaterOrEqual(t, len(result.Completions), 6) // -o, --output, -v, --verbose, -f, --format
 }
+
+func TestRebuildColonSeparatedArgs_Empty(t *testing.T) {
+	assert.Equal(t, []string{}, rebuildColonSeparatedArgs([]string{}))
+}
+
+func TestRebuildColonSeparatedArgs_NoColons(t *testing.T) {
+	args := []string{"a", "b", "c"}
+	assert.Equal(t, []string{"a", "b", "c"}, rebuildColonSeparatedArgs(args))
+}
+
+func TestRebuildColonSeparatedArgs_SingleColon(t *testing.T) {
+	args := []string{"a", ":", "b"}
+	assert.Equal(t, []string{"a:b"}, rebuildColonSeparatedArgs(args))
+}
+
+func TestRebuildColonSeparatedArgs_MultipleColons(t *testing.T) {
+	args := []string{"a", ":", "b", ":", "c"}
+	assert.Equal(t, []string{"a:b:c"}, rebuildColonSeparatedArgs(args))
+}
+
+func TestRebuildColonSeparatedArgs_ColonAtEnd(t *testing.T) {
+	args := []string{"a", "b", ":"}
+	result := rebuildColonSeparatedArgs(args)
+	assert.Equal(t, []string{"a", "b:"}, result)
+}
+
+func TestRebuildColonSeparatedArgs_ColonAtStart(t *testing.T) {
+	args := []string{":", "a", "b"}
+	result := rebuildColonSeparatedArgs(args)
+	// A leading colon joins with the next arg
+	assert.Equal(t, []string{":", "a", "b"}, result)
+}
+
+func TestRebuildColonSeparatedArgs_MixedNormalAndColon(t *testing.T) {
+	args := []string{"config", ":", "get", "d"}
+	result := rebuildColonSeparatedArgs(args)
+	assert.Equal(t, []string{"config:get", "d"}, result)
+}
+
+func TestRebuildColonSeparatedArgs_ConsecutiveColons(t *testing.T) {
+	args := []string{"a", ":", ":", "b"}
+	result := rebuildColonSeparatedArgs(args)
+	assert.Equal(t, []string{"a::b"}, result)
+}
+
+func TestRebuildColonSeparatedArgs_SingleElement(t *testing.T) {
+	args := []string{"hello"}
+	assert.Equal(t, []string{"hello"}, rebuildColonSeparatedArgs(args))
+}
+
+func TestRebuildColonSeparatedArgs_ColonOnly(t *testing.T) {
+	args := []string{":"}
+	result := rebuildColonSeparatedArgs(args)
+	assert.Equal(t, []string{":"}, result)
+}