from-csv: print sqlite's stderr as text instead of hex#1042
Open
c-tonneslan wants to merge 1 commit into
Open
Conversation
The error path stringified the captured stderr with %x, which turned sqlite3's actual message into a wall of hex digits. The reporter saw "could not load csv into new database file: exit status 1: 4572726f723a206e656172..." and had to manually hex-decode it to see what went wrong. Switch to %s and trim trailing whitespace so the message reads as sqlite intended. Updates tursodatabase#810. Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates #810.
The error path stringified the captured stderr with `%x`, which turned sqlite3's actual message into a wall of hex digits. The reporter saw `could not load csv into new database file: exit status 1: 4572726f723a206e656172...` and had to hex-decode it manually to see what went wrong.
Switch to `%s` and trim trailing whitespace so the message reads as sqlite intended. Leaves the validation half of the issue (rejecting bad table names up front) for a separate change.