Skip to content

Conversation

@mihai-c-tudor
Copy link
Contributor

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

@mihai-c-tudor mihai-c-tudor requested a review from jerryz123 March 29, 2024 23:05
@mihai-c-tudor mihai-c-tudor self-assigned this Mar 29, 2024
@mihai-c-tudor mihai-c-tudor force-pushed the merge-spikerocc branch 2 times, most recently from b1bc61f to d17d283 Compare April 2, 2024 17:26
Copy link
Contributor

@jerryz123 jerryz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This overall looks pretty good.
One naming nit though, I think its better if we rename every variable/function that has accel in the name to rocc, so it more precisely conveys that this interfaces hardware RoCC accelerators to the SpikeTile.

@mihai-c-tudor
Copy link
Contributor Author

Makes sense, changes implemented.

@mihai-c-tudor mihai-c-tudor requested a review from jerryz123 April 4, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants