-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USWDS-Site: Add table accessibility tests page #2538
Merged
Merged
Changes from 2 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
48aa275
Set up table accessibility tests page
amyleadem 017c10c
Add PR number to changelogs
amyleadem 4db191a
Update checklist copy; Remove 1.4.11, 1.4.4, 1.4.12
amyleadem 5702b64
Format code
amyleadem 28595e8
Move compliance tag to styleguide.html
amyleadem f79f214
Add top margin to table intro
amyleadem 44203ce
Assign data needed for compliance tag
amyleadem 56935a1
Move assignments to compliance-tag.html
amyleadem a675795
Add issue number for 2.1.1 exception
amyleadem e70b387
Update status on 2.1.2 to pass
amyleadem c5517e0
Update table test version to 3.7.1
amyleadem e664553
Remove test item for 4.1.1
amyleadem 58ef529
Update changelog dates
amyleadem 911381c
Small copy tweaks for table tests
amyleadem 6f25085
Edit the exception description for 2.1.1
amyleadem 4cf860c
Update 2.1.1 --> 2.4.6
amyleadem File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
--- | ||
permalink: /components/table/accessibility-tests/ | ||
layout: styleguide | ||
component: | ||
name: table | ||
title: Table accessibility tests | ||
category: Components | ||
lead: Any USWDS table should pass these manual accessibility tests. | ||
changelog: | ||
key: 'component-table-accessibility' | ||
--- | ||
|
||
{% include accessibility-tests/index.html %} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,135 @@ | ||
title: Table | ||
component_status: pass | ||
test_items: | ||
# General tests | ||
- summary: Color is not the only method used to convey meaning in a table. | ||
summary_additional: | | ||
When you view the table on a page, | ||
you never have to rely on color alone to understand the table's meaning. | ||
test_status: pass | ||
test_type: general | ||
version_tested: 3.6.0 | ||
wcag_criterion: 1.4.1 | ||
- summary: Table content meets color contrast requirements. | ||
summary_additional: | | ||
When you view the content in a table and use ANDI or color contrast analyzer to look at the hex colors, | ||
contrast between the table background and text is at least 4.5:1. | ||
test_status: pass | ||
test_type: general | ||
version_tested: 3.6.0 | ||
wcag_criterion: 1.4.3 | ||
- summary: Table background color has sufficient contrast with page background color. | ||
summary_additional: | | ||
When you view a table with a background color, | ||
the table's background color contrasts with the page's color, and it's obvious which content belongs in the table vs. on the surrounding page. | ||
test_status: pass | ||
test_type: general | ||
version_tested: 3.6.0 | ||
wcag_criterion: 1.4.11 | ||
# Zoom/screen magnification tests | ||
- summary: Table content does not get cut off when text size is increased. | ||
summary_additional: | | ||
When you increase text size by 200%, | ||
content in the table remains visible without the need to scroll. | ||
test_status: pass | ||
test_type: zoom | ||
version_tested: 3.6.0 | ||
wcag_criterion: 1.4.4 | ||
- summary: Table content is visible and functional when screen is magnified. | ||
summary_additional: | | ||
When you zoom the screen to 200%, | ||
amyleadem marked this conversation as resolved.
Show resolved
Hide resolved
|
||
content in the table remains visible and does not overlap with other content. | ||
test_status: pass | ||
test_type: zoom | ||
version_tested: 3.6.0 | ||
wcag_criterion: 1.4.10 | ||
- summary: Table content does not get cut off when text spacing is changed. | ||
summary_additional: | | ||
When you adjust text spacing in the following ways, all content remains visible without overlap or the need for horizontal scrolling: | ||
- line height is at least 1.5 times the font size, | ||
- letter spacing is at least 0.12 times the font size, | ||
- the spacing following paragraphs is at least 2 times the font size, | ||
- and word spacing is at least 0.16 times the font size, | ||
test_status: pass | ||
test_type: zoom | ||
version_tested: 3.6.0 | ||
wcag_criterion: 1.4.12 | ||
# Keyboard navigation tests | ||
- summary: Table elements can be navigated by keyboard without special cues. | ||
summary_additional: | | ||
When you use a keyboard to navigate a table, | ||
a user can navigate using arrow keys or the tab key with no unexpected cues or instruction. | ||
test_status: exception | ||
status_details: | | ||
The table does not scroll with JAWS. | ||
A user would need to use their mouse to follow along with the focus indicator in JAWS. | ||
test_type: keyboard | ||
amyleadem marked this conversation as resolved.
Show resolved
Hide resolved
|
||
version_tested: | ||
wcag_criterion: 2.1.1 | ||
- summary: Table cells do not trap focus. | ||
summary_additional: | | ||
When you use a keyboard to navigate a table, | ||
you can easily navigate in and out of the table cells using only keystrokes. | ||
test_status: | ||
test_type: keyboard | ||
version_tested: | ||
amyleadem marked this conversation as resolved.
Show resolved
Hide resolved
|
||
wcag_criterion: 2.1.2 | ||
- summary: Focus indicator is clear on interactive items in tables. | ||
summary_additional: | | ||
When you use a keyboard to navigate a table, | ||
a focus indicator appears around all interactive elements (e.g. arrows for sorting, links). | ||
amyleadem marked this conversation as resolved.
Show resolved
Hide resolved
|
||
test_status: pass | ||
test_type: keyboard | ||
version_tested: 3.5.0 | ||
wcag_criterion: 2.4.7 | ||
# Screen reader tests | ||
- summary: | ||
summary_additional: | | ||
When using a screen reader to navigate a table, | ||
the screen reader speaks one cell at a time and announces the correct header cells for context. | ||
Tip: When using JAWS press the `ctrl` + `alt` keys to navigate within the table. | ||
amyleadem marked this conversation as resolved.
Show resolved
Hide resolved
|
||
test_status: pass | ||
test_type: screen_reader | ||
version_tested: 3.6.0 | ||
wcag_criterion: 1.3.1 | ||
- summary: Table cells are read in a logical order. | ||
summary_additional: | | ||
When using a screen reader to navigate a table, | ||
you hear the table cells for an entire row read in order from left to right before moving down to the next row. | ||
amyleadem marked this conversation as resolved.
Show resolved
Hide resolved
|
||
test_status: pass | ||
test_type: screen_reader | ||
version_tested: 3.6.0 | ||
wcag_criterion: 1.3.2 | ||
- summary: Merged table headers are correctly associated with table cells. | ||
summary_additional: | | ||
When using a screen reader to navigate a table with merged header cells, | ||
you can understand which lower-level data is organized under merged header cells. | ||
test_status: pass | ||
test_type: screen_reader | ||
version_tested: 3.6.0 | ||
wcag_criterion: 2.1.1 | ||
amyleadem marked this conversation as resolved.
Show resolved
Hide resolved
|
||
- summary: Table cells are associated with their related table headers. | ||
summary_additional: | | ||
When using a screen reader to navigate a table, | ||
you can clearly hear which column head the data falls under. | ||
amyleadem marked this conversation as resolved.
Show resolved
Hide resolved
|
||
test_status: pass | ||
test_type: screen_reader | ||
version_tested: 3.6.0 | ||
wcag_criterion: 2.4.6 | ||
- summary: Screen readers correctly announce table elements. | ||
summary_additional: | | ||
When using a screen reader to navigate a table, | ||
the screen reader announces the table and calls the header rows "column headers". | ||
amyleadem marked this conversation as resolved.
Show resolved
Hide resolved
|
||
test_status: pass | ||
test_type: screen_reader | ||
version_tested: 3.6.0 | ||
wcag_criterion: 4.1.1 | ||
amyleadem marked this conversation as resolved.
Show resolved
Hide resolved
|
||
- summary: Table elements have the appropriate name, role, and state. | ||
summary_additional: | | ||
When using a screen reader to navigate a table, | ||
the screen reader announces the name and role of interactive elements such as scrolling, sorting, and clicking. | ||
For sortable tables, you hear whether the column is sorted and how it is sorted. | ||
test_status: pass | ||
test_type: screen_reader | ||
version_tested: 3.6.0 | ||
wcag_criterion: 4.1.2 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
title: Table accessibility tests | ||
type: component | ||
changelogURL: | ||
items: | ||
- date: NNNN-NN-NN | ||
summary: Added accessibility tests page. | ||
affectsGuidance: true | ||
githubPr: 2538 | ||
githubRepo: uswds-site |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note
I excluded the the tests for 1.3.2, 1.4.11, 1.4.4, and 1.4.12. I have included the reasoning for each in Column L of the test spreadsheet. Let me know if you want to include any of these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the comments I agree on all counts based on our discussion; we can circle back to adding those as we add further testing guidance and or nuance to the table component.