Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USWDS-Site: Add table accessibility tests page #2538

Merged
merged 16 commits into from
Mar 21, 2024
Merged

Conversation

amyleadem
Copy link
Contributor

@amyleadem amyleadem commented Mar 19, 2024

Summary

Important

We need to confirm the changelog dates before merge.

Resources

Related issue

Closes #2534

Preview link

Testing and review

  1. Confirm that both the main component page and the accessibility tests page has the correct compliance tag at the top.
    1. Confirm that the compliance tag does NOT show up on pages that do not have a related a11y tests page.
  2. Confirm that the main component page links to the accessibility tests page in the side navigation.
  3. Confirm that the main component page links to the accessibility tests page in the accessibility section.
    1. Confirm that this text references the correct component. For example "Test the icon in your own project."
  4. Check that accessibility tests page provides the correct counts for each test status type.
  5. Confirm the test checklist summaries and data are accurate.
  6. Confirm no visual issues.
  7. Confirm there is an appropriate changelog entry on both the main component page and the accessibility tests page.

Copy link
Contributor Author

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alex-hull @amycole501 @sarah-sch @finekatie
This is ready for your review. I've added some comments below with some open questions. Please let me know if you have any questions or comments.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

I excluded the the tests for 1.3.2, 1.4.11, 1.4.4, and 1.4.12. I have included the reasoning for each in Column L of the test spreadsheet. Let me know if you want to include any of these.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the comments I agree on all counts based on our discussion; we can circle back to adding those as we add further testing guidance and or nuance to the table component.

@amyleadem amyleadem marked this pull request as ready for review March 19, 2024 23:56
@alex-hull
Copy link

@amyleadem It looks like the second "passes with exceptions" is not the yellow that the first one. It also does not look like it is in the table at the top of the page.

@amyleadem
Copy link
Contributor Author

@alex-hull The second "pass with exceptions" item is only showing up that way because it didn't have a test status in the spreadsheet. Can you respond to the questions in the related comment above about how to move forward with that bb?

@amyleadem
Copy link
Contributor Author

amyleadem commented Mar 20, 2024

Update to the conversation immediately above: I changed the status of the second "pass with exceptions" item to "passed" based on the recent update to the spreadsheet. Updated in e70b387

Copy link

@amycole501 amycole501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made comments but overall the page looks great! Nothing major of note to change.

@amyleadem amyleadem requested a review from sarah-sch March 20, 2024 20:49
@amyleadem
Copy link
Contributor Author

@sarah-sch Your requested updates are now live. Let me know if you need anything else.

Copy link
Contributor

@sarah-sch sarah-sch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve as an MVP after fed review

@amyleadem
Copy link
Contributor Author

amyleadem commented Mar 20, 2024

@thisisdano @annepetersen This is ready for your review. FYI - I am able to get pa11y tests to pass locally, but they are still crashing here. Going to keep trying to get them to pass here 🏄

🏄🏄🏄 Tests passed! 🏄🏄🏄

@thisisdano thisisdano merged commit b596d09 into main Mar 21, 2024
11 checks passed
@thisisdano thisisdano deleted the al-table-checklist branch March 21, 2024 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CC a11y: publish Table checklist - create PR
5 participants