-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USWDS-Site: Add table accessibility tests page #2538
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alex-hull @amycole501 @sarah-sch @finekatie
This is ready for your review. I've added some comments below with some open questions. Please let me know if you have any questions or comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note
I excluded the the tests for 1.3.2, 1.4.11, 1.4.4, and 1.4.12. I have included the reasoning for each in Column L of the test spreadsheet. Let me know if you want to include any of these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the comments I agree on all counts based on our discussion; we can circle back to adding those as we add further testing guidance and or nuance to the table component.
@amyleadem It looks like the second "passes with exceptions" is not the yellow that the first one. It also does not look like it is in the table at the top of the page. |
@alex-hull The second "pass with exceptions" item is only showing up that way because it didn't have a test status in the spreadsheet. Can you respond to the questions in the related comment above about how to move forward with that bb? |
- This reflects the new "last tested" date
Update to the conversation immediately above: I changed the status of the second "pass with exceptions" item to "passed" based on the recent update to the spreadsheet. Updated in e70b387 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made comments but overall the page looks great! Nothing major of note to change.
@sarah-sch Your requested updates are now live. Let me know if you need anything else. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve as an MVP after fed review
🏄🏄🏄 Tests passed! 🏄🏄🏄 |
Summary
Important
We need to confirm the changelog dates before merge.
Resources
Related issue
Closes #2534
Preview link
Testing and review