-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USWDS-Site: Add typography accessibility tests page #2540
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amycole501 @alex-hull @sarah-sch @finekatie
This is ready for your review. Please take a look at the comments below. Let me know if you need any changes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the inline changes I've noted, please update the text above the table at the top to read, "The USWDS team did three tests based on WCAG 2.1 AA success criteria." (Because it's >10 three should be spelled out)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The page looks good; I added some comments and input but I think it's in good shape for moving forward.
🏄🏄🏄 Tests passed! 🏄🏄🏄 |
Summary
Important
We need to confirm the changelog dates before merge.
Resources
Related issue
Closes #2533
Preview link
Testing and review