Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USWDS-Site: Add typography accessibility tests page #2540

Merged
merged 13 commits into from
Mar 21, 2024

Conversation

amyleadem
Copy link
Contributor

@amyleadem amyleadem commented Mar 20, 2024

Summary

  • Added typography accessibility tests page.
  • Moved compliance-tag.html reference to styleguide.html

Important

We need to confirm the changelog dates before merge.

Resources

Related issue

Closes #2533

Preview link

Testing and review

  1. Confirm that both the main component page and the accessibility tests page has the correct compliance tag at the top.
    1. Confirm that the compliance tag does NOT show up on pages that do not have a related a11y tests page.
  2. Confirm that the main component page links to the accessibility tests page in the side navigation.
  3. Check that accessibility tests page provides the correct counts for each test status type.
  4. Confirm the test checklist summaries and data are accurate.
  5. Confirm no visual issues.
  6. Confirm there is an appropriate changelog entry on both the main component page and the accessibility tests page.

@amyleadem amyleadem changed the title USWDS-Site: Add table accessibility tests page USWDS-Site: Add typography accessibility tests page Mar 20, 2024
@amyleadem amyleadem marked this pull request as ready for review March 20, 2024 17:03
Copy link
Contributor Author

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amycole501 @alex-hull @sarah-sch @finekatie
This is ready for your review. Please take a look at the comments below. Let me know if you need any changes!

Copy link
Contributor

@sarah-sch sarah-sch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the inline changes I've noted, please update the text above the table at the top to read, "The USWDS team did three tests based on WCAG 2.1 AA success criteria." (Because it's >10 three should be spelled out)

Copy link

@amycole501 amycole501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The page looks good; I added some comments and input but I think it's in good shape for moving forward.

@amyleadem
Copy link
Contributor Author

amyleadem commented Mar 20, 2024

@thisisdano @annepetersen This is ready for your review. FYI - I am able to get pa11y tests to pass locally, but they are still crashing here. Going to keep trying to get them to pass here 🏄

🏄🏄🏄 Tests passed! 🏄🏄🏄

@thisisdano thisisdano merged commit 239bb0f into main Mar 21, 2024
11 checks passed
@thisisdano thisisdano deleted the al-typography-checklist branch March 21, 2024 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CC a11y: publish Typography checklist - create PR
5 participants