Skip to content

Conversation

enjoy-binbin
Copy link
Member

@enjoy-binbin enjoy-binbin commented Aug 17, 2025

We now have #2688 SYNCSLOTS CAPA, remove the outupdated comment.

We skip unknown key/value pairs forwards compatibility.
Introduced in valkey-io#1949.

Signed-off-by: Binbin <[email protected]>
@zuiderkwast
Copy link
Contributor

We have SYNCSLOTS CAPA now: #2688. We don't use it now, but for the future it provides a way to send information where unknown information will be ignored by older nodes.

Do we still need this PR or can we close it?

@murphyjacob4
Copy link
Contributor

Yeah I agree - let's use SYNCSLOTS CAPA - if anything unknown arrives outside of that - it would be unexpected. @enjoy-binbin wdyt?

@enjoy-binbin
Copy link
Member Author

i normally like the ignore way in internal command, but i guess capa can work well as well, let's just remove the outupdated comment.

Signed-off-by: Binbin <[email protected]>
@enjoy-binbin enjoy-binbin changed the title Ignore unknown key/value pairs in CLUSTER SYNCSLOTS ESTABLISH Remove the outupdated unknown key/value pairs comment in CLUSTER SYNCSLOTS ESTABLISH Oct 15, 2025
Copy link

codecov bot commented Oct 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.62%. Comparing base (54da834) to head (b8ad8cd).

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #2498      +/-   ##
============================================
- Coverage     72.64%   72.62%   -0.02%     
============================================
  Files           128      128              
  Lines         71278    71278              
============================================
- Hits          51777    51765      -12     
- Misses        19501    19513      +12     
Files with missing lines Coverage Δ
src/cluster_migrateslots.c 92.07% <ø> (-0.16%) ⬇️

... and 15 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants