Skip to content

Remove the outupdated unknown key/value pairs comment in CLUSTER SYNCSLOTS ESTABLISH #2498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 17, 2025
+1 −2
Merged

Remove the outupdated unknown key/value pairs comment in CLUSTER SYNCSLOTS ESTABLISH #2498

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5dc2775
Ignore unknown key/value pairs in CLUSTER SYNCSLOTS ESTABLISH
enjoy-binbin Aug 17, 2025
de82c78
Merge remote-tracking branch 'upstream/unstable' into slot_ignore
enjoy-binbin Oct 15, 2025
b8ad8cd
remove comment
enjoy-binbin Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/cluster_migrateslots.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -538,8 +538,7 @@ void clusterCommandSyncSlotsEstablish(client *c) {
return;
}

/* Order agnostic. We skip unknown key/value pairs forwards
* compatibility. */
/* Order agnostic. */
bool is_tracking_only = c->flag.primary || c->id == CLIENT_ID_AOF;
int i = 3;
while (i < c->argc) {
Expand Down
Loading