-
Notifications
You must be signed in to change notification settings - Fork 412
[Place] Expand search range for sparse blocks #2960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
amin1377
wants to merge
47
commits into
master
Choose a base branch
from
placement_search_range
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+111
−60
Open
Changes from 33 commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
0c355d8
[type] add is_fixed to t_bb
amin1377 42d06e7
[vpr][type] add comments for t_bb
amin1377 b80abb5
[place] expand search range if the number of blocks in the column is …
amin1377 0f038dc
make format
amin1377 271640b
[base][types] remove is_fixed from t_bb
amin1377 a2ae770
[vpr][place] adjust search range in another function
amin1377 01b55e8
[vpr][place] fix a typo
amin1377 df7a0c4
Merge branch 'master' of https://github.com/verilog-to-routing/vtr-ve…
amin1377 75e9474
[vpr][place] fix a typo
amin1377 2e4dc59
[vpr][place] clean up the code
amin1377 34c7571
[vpr][place] don't continue if there is no compatible block in the gi…
amin1377 c94c8b8
[vpr][place] check lower_iter afer adjustment
amin1377 512eb7c
[vpr][place] add adjust_search_range
amin1377 1da6e6d
[vpr][place] add adjust_search_range
amin1377 a1d67f7
make format
amin1377 9c4057a
Merge branch 'master' into placement_search_range
amin1377 a27a74f
Merge branch 'master' of https://github.com/verilog-to-routing/vtr-ve…
amin1377 58a3522
[vpr][place] use is_io_type to determine whether a block is of the ty…
amin1377 43e33fa
[libs][libarch] add is_io_type for logical types
amin1377 3ea75f2
[vpr][place] add comment for adjust_search_range
amin1377 ac7a821
[test] update strong results
amin1377 6871fc9
[test] update srong odin
amin1377 84790cf
[test] update basic_timing results
amin1377 9f8e498
[test] update parmys and odin res
amin1377 e2b0c9d
[test] update nightly test 1 res
amin1377 cf86a33
Merge branch 'master' of https://github.com/verilog-to-routing/vtr-ve…
amin1377 a97d8db
[vpr][place] don't skip the x if search range min is below the y found
amin1377 2dc79c9
Merge branch 'master' of https://github.com/verilog-to-routing/vtr-ve…
amin1377 fe99d5e
[vpr][place] search for another column if block is not io and lower_b…
amin1377 f9e8517
[vpr][place] remove adjust search range and adjust it inside find_com…
amin1377 dae25cc
[vpr][place] use a constexpr to compare the number of blocks in column
amin1377 ade994b
[vpr][place] pass block_constraint parameter to relevant functions in…
amin1377 96e9cc5
make format
amin1377 4a6e333
[vpr][place] move MIN_BLK_PER_COLUMN_EXPAND into the routine
amin1377 caaf456
make format
amin1377 af29e9d
[vpr][place] expand search range if block is io
amin1377 7070d1b
Revert "[vpr][place] expand search range if block is io"
amin1377 7c96daa
Revert "make format"
amin1377 057d0a9
Revert "[vpr][place] move MIN_BLK_PER_COLUMN_EXPAND into the routine"
amin1377 8c4a49b
Revert "make format"
amin1377 d416295
Revert "[vpr][place] pass block_constraint parameter to relevant func…
amin1377 4152246
Revert "[vpr][place] use a constexpr to compare the number of blocks …
amin1377 cfa8210
Revert "[vpr][place] remove adjust search range and adjust it inside …
amin1377 17ec4a0
[vpr][place] move adjust_search_range to move_utils.h so it can be ac…
amin1377 5e8a495
[vpr][place] add adjust search range to find centriod neighbour
amin1377 36e1eb6
[vpr][place] remove a special case in find_compatible_compressed_loc_…
amin1377 59a08eb
Merge branch 'master' of https://github.com/verilog-to-routing/vtr-ve…
amin1377 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a comment. Better name would be MIN_BLK_PER_COLUMN_EXPAND (or something like that). Current name makes it sound like we can't have fewer blocks than that in a column.
I also think this should be pushed down to the routine that uses it, if it is only used in one place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved the variable to the routine and added the following comment: