[CI] Added Test Suite Verification to CI #3121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexandreSinger
force-pushed
the
feature-ci-task-list-checker
branch
3 times, most recently
from
7286cd2 to
7604811
Compare
AlexandreSinger
changed the title
|
This PR adds a new CI test which will check that all of the test suites that we use in the CI have all of the tasks they are supposed to have in their task lists. The following test suites have tasks that are not in their task list:
Added the test in these suites as ignored for now and will try and add as many of them as I can in a future PR. |
vaughnbetz
reviewed
Jun 9, 2025
Found that we were regressing on many features in VTR due to tasks being added to the appropriate test suite directory, but not being included in the necessary task list. As such, it appeared as though the tests were being run, but in reality they were not. Added a script which will be run by the CI which will verify that all of the test suites that we care about have all their tasks in the appropriate task list. From this tool, found many tasks which were not in the task lists. Marked these tasks as "ignored" for now. These should be handled in a separate PR.
AlexandreSinger
force-pushed
the
feature-ci-task-list-checker
branch
from
7604811 to
93fc0fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found that we were regressing on many features in VTR due to tasks being
added to the appropriate test suite directory, but not being included in
the necessary task list. As such, it appeared as though the tests were
being run, but in reality they were not.
Added a script which will be run by the CI which will verify that all of
the test suites that we care about have all their tasks in the
appropriate task list.
From this tool, found many tasks which were not in the task lists.
Marked these tasks as "ignored" for now. These should be handled in a
separate PR.