Skip to content

Conversation

@gcanlin
Copy link
Contributor

@gcanlin gcanlin commented Oct 23, 2025

What this PR does / why we need it?

Closes #3508.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

No need to test. All scripts and Python code in the docs has been tested.

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new tutorial for running InternVL series models on a single NPU. The tutorial is well-structured and provides clear instructions for both offline inference and online serving. However, there is a significant issue with the model path used in the examples, which points to a non-public model. This will prevent users from following the tutorial. My review includes a comment to address this.

Signed-off-by: gcanlin <[email protected]>
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 23, 2025
Signed-off-by: gcanlin <[email protected]>
Signed-off-by: gcanlin <[email protected]>
@Yikun
Copy link
Collaborator

Yikun commented Oct 24, 2025

Please add an accuracy test with same parameter with doc before merge.

https://github.com/vllm-project/vllm-ascend/tree/main/tests%2Fe2e%2Fmodels%2Fconfigs

@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation merge-conflicts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: Multi-Modal Tasks

2 participants