[FOR DISCUSSION] continue-on-error for ruby-head, jruby #533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faisal
force-pushed
the
continue-on-experimental-error
branch
from
2254a68 to
e60c945
Compare
faisal
changed the title
3 tasks
etagwerker
approved these changes
Oct 14, 2025
Collaborator
etagwerker
left a comment
etagwerker
left a comment
There was a problem hiding this comment.
@faisal This looks good to me. Thank you! 🙏🏼
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extracts the workflow changes from #508 so we get green even on failures in the experimental jruby and ruby-head runs. In its current state, it removes the monkeypatch to allow success on ruby-head, so the ruby-head run fails although GitHub shows it as passing. If we like the change then I will remove the monkeypatch reversion and squash the rest to one commit.
What do you all think?
Check list: