log: make WLOG macro a noop if logging disabled #836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
even if logging is disabled, the strings are still included in the binary. This is because the compiler does not see that wolfSSH_Log() is compiled as a noop. By making WLOG a noop if wolfSSH_Log is we reduce the compiled so-file by ~50k (about 25%).
|
I see now that |
|
Thanks @AxlLind for the suggestion! I'm going to treat this as a bug/enhancement report and open a pull request shortly for it. If you have some more changes in mind, please reach out to [email protected] to go through being setup as a contributor. Again the feedback on wolfSSH and suggested code changes is greatly appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
even if logging is disabled, the strings are still included in the binary. This is because the compiler does not see that wolfSSH_Log() is compiled as a noop (perhaps solved with lto, haven't tried).
By making WLOG a noop if wolfSSH_Log is we reduce the compiled so-file by ~50k (about 25%).
Compiling on my machine for linux x86_64
libwolfssh.so.7.10.2goes from197kto144k. This seems significant.One downside is potential warnings about variables which are only used in WLOG invocations. This only happened in one place in the code base, so I would argue it's worth it.