Skip to content

log: make WLOG macro a noop if logging disabled #836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

log: make WLOG macro a noop if logging disabled #836

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/internal.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11281,6 +11281,7 @@ int wolfSSH_RsaVerify(const byte *sig, word32 sigSz,
compare = ConstantCompare(encDigest, checkDigest, encDigestSz);

if (checkDigestSz < 0 || sizeCompare || compare) {
(void)loc; // unused if log disabled
WLOG(WS_LOG_DEBUG, "%s: %s", loc, "Bad RSA Verify");
ret = WS_RSA_E;
}
Expand Down
6 changes: 4 additions & 2 deletions wolfssh/log.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,15 +72,17 @@ WOLFSSH_API int wolfSSH_LogEnabled(void);
WOLFSSH_API void wolfSSH_Log(enum wolfSSH_LogLevel,
const char *const, ...) FMTCHECK;

#if defined(DEBUG_WOLFSSH) || defined(WOLFSSH_SSHD)
#define WLOG(...) do { \
if (wolfSSH_LogEnabled()) \
wolfSSH_Log(__VA_ARGS__); \
} while (0)

#else
#define WLOG(...)
#endif

#ifdef __cplusplus
}
#endif

#endif /* _WOLFSSH_LOG_H_ */