Skip to content

[ci] Clean-up and simplify CODEOWNERS #8066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −16
Open

[ci] Clean-up and simplify CODEOWNERS #8066

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 8 additions & 16 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,26 +11,18 @@
# This should make it easy to add new rules without breaking existing ones.

# Global rule:
* @wpilibsuite/wpilib
* @PeterJohnson @ThadHouse @calcmogul @rzblue
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this cause GitHub to tag all the individuals and give the impression all named individuals need to approve the PR?

Copy link
Member

@rzblue rzblue Jul 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sounds like it will only require one approval per match pattern

https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners#codeowners-and-branch-protection

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but my experience is that's super non-obvious

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you worried about it from the reviewers perspective, or worried that a PR author will go an follow up with a bunch of people?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latter.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if you configure new teams in the GitHub organization and use them here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we discussed this on Thursday and that’s the plan.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The flipside is that using the groups makes it harder to see who the real reviewers are, as seen in this PR: #8219


/cameraserver/ @wpilibsuite/camera-server
/epilogue-*/ @SamCarlberg @PeterJohnson @ThadHouse @calcmogul @rzblue

/cscore/ @wpilibsuite/camera-server
/romiVendordep/ @zhiquanyeo @jpokornyiii @PeterJohnson @ThadHouse @calcmogul @rzblue

/hal/ @wpilibsuite/hardware
/hal/src/main/java/**/sim/ @wpilibsuite/simulation
/hal/src/main/native/include/mockdata/ @wpilibsuite/simulation
/hal/src/main/native/include/simulation/ @wpilibsuite/simulation
/hal/src/main/native/sim/ @wpilibsuite/simulation
/simulation/ @zhiquanyeo @jpokornyiii @PeterJohnson @ThadHouse @calcmogul @rzblue

/ntcore/ @wpilibsuite/network-tables
/wpilibNewCommands/ @Starlight220 @PeterJohnson @ThadHouse @calcmogul @rzblue

/simulation/ @wpilibsuite/simulation
/wpilib?Examples/ @sciencewhiz @jasondaming @Starlight220 @PeterJohnson @ThadHouse @calcmogul @rzblue

/wpilibNewCommands/ @wpilibsuite/commandbased
/wpiunits/ @SamCarlberg @PeterJohnson @ThadHouse @calcmogul @rzblue

/wpilibcExamples/ @wpilibsuite/wpilib @wpilibsuite/documentation

/wpilibjExamples/ @wpilibsuite/wpilib @wpilibsuite/documentation

/wpiutil/ @PeterJohnson
/xrpVendordep/ @zhiquanyeo @jpokornyiii @PeterJohnson @ThadHouse @calcmogul @rzblue
Loading