[wpimath] Add interpolators for measures #8178
Open
+134
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calcmogul
changed the title
calcmogul
changed the title
wpimath/src/test/java/edu/wpi/first/math/interpolation/InterpolatingMeasuresTreeMapTest.java
Outdated
Show resolved
Hide resolved
wpimath/src/test/java/edu/wpi/first/math/interpolation/InterpolatingMeasuresTreeMapTest.java
Outdated
Show resolved
Hide resolved
Comment on lines
57
to
63
| table.put(Units.Inches.of(Units.Meters.of(125.0).in(Units.Inches)), Units.Meters.of(450.0)); | ||
| table.put(Units.Meters.of(200.0), Units.Feet.of(Units.Meters.of(510.0).in(Units.Feet))); | ||
| table.put( | ||
| Units.Centimeters.of(Units.Meters.of(268.0).in(Units.Centimeters)), | ||
| Units.Meters.of(525.0)); | ||
| table.put( | ||
| Units.Inches.of(Units.Meters.of(312.0).in(Units.Inches)), | ||
| Units.Feet.of(Units.Meters.of(550.0).in(Units.Feet))); | ||
| table.put(Units.Meters.of(326.0), Units.Meters.of(650.0)); |
There was a problem hiding this comment.
Why doesn't this just use Units.Meters.of()?
There was a problem hiding this comment.
to confirm it works properly if it is constructed with different units
There was a problem hiding this comment.
This doesn't feel like a super clear way to do that, but I guess it works. Maybe just add a comment to explain it?
5 tasks
github-actions
bot
added
component: ntcore
Signed-off-by: Zach Harel <[email protected]>
…eInterpolator Signed-off-by: Zach Harel <[email protected]>
Signed-off-by: Zach Harel <[email protected]>
Signed-off-by: Zach Harel <[email protected]>
…eInterpolator Signed-off-by: Zach Harel <[email protected]>
…eeMapTest (and then delete InterpolatingMeasuresTreeMapTest) Signed-off-by: Zach Harel <[email protected]>
… of star import for consistency Signed-off-by: Zach Harel <[email protected]>
Signed-off-by: Zach Harel <[email protected]>
…ods in Interpolator and InverseInterpolator Signed-off-by: Zach Harel <[email protected]>
…Util and update tests accordingly Signed-off-by: Zach Harel <[email protected]>
zachwaffle4
force-pushed
the
unit-interpolation
branch
from
6c2e4f1 to
634edc8
Compare
github-actions
bot
removed
component: ntcore
Signed-off-by: Zach Harel <[email protected]>
…e in interpolation methods in MathUtil Signed-off-by: Zach Harel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is also trivial to implement but for situations where we want to be unit-safe it would be nice to not have to define an interpolator and inverse interpolator every time we want an interpolator map with a measure