XWIKI-23573: Errors when setting a previously uploaded image as avatar #4681
+5
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Took into account the possibility of the targetElement being the icon inside of the button.
mflorea
reviewed
Oct 22, 2025
Comment on lines
+640
to
+641
| let deleteTool = event.element(); | ||
| if (!deleteTool.hasClassName('btn')) deleteTool = deleteTool.up('.btn'); |
There was a problem hiding this comment.
I'd try to use the native API:
Suggested change
| let deleteTool = event.element(); | |
| if (!deleteTool.hasClassName('btn')) deleteTool = deleteTool.up('.btn'); | |
| const deleteTool = event.target.closest('.btn'); |
See https://developer.mozilla.org/en-US/docs/Web/API/Event/target and https://developer.mozilla.org/en-US/docs/Web/API/Element/closest (note that closest starts from the element is being called on).
Comment on lines
+684
to
+685
| let targetElement = event.element(); | ||
| if (!targetElement.hasClassName('btn')) targetElement = targetElement.up('.btn'); |
There was a problem hiding this comment.
Suggested change
| let targetElement = event.element(); | |
| if (!targetElement.hasClassName('btn')) targetElement = targetElement.up('.btn'); | |
| const targetElement = event.target.closest('.btn'); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-23573
Changes
Description
Clarifications
Screenshots & Video
None
Executed Tests
Built changes with
mvn clean install -f xwiki-platform-core/xwiki-platform-attachment/xwiki-platform-attachment-ui -PqualityRan the docker tests:
mvn clean install -f xwiki-platform-core/xwiki-platform-attachment/xwiki-platform-attachment-test/xwiki-platform-attachment-test-dockerExpected merging strategy