Skip to content

XWIKI-23573: Errors when setting a previously uploaded image as avatar #4681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 27, 2025
Merged

XWIKI-23573: Errors when setting a previously uploaded image as avatar #4681

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
57d42fd
XWIKI-23573: Errors when setting a previously uploaded image as avatar
Sereza7 Oct 17, 2025
b501a92
XWIKI-23573: Errors when setting a previously uploaded image as avatar
Sereza7 Oct 24, 2025
a7d41df
XWIKI-23573: Errors when setting a previously uploaded image as avatar
Sereza7 Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...m-attachment/xwiki-platform-attachment-ui/src/main/resources/XWiki/AttachmentSelector.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -637,7 +637,7 @@ $xwiki.jsx.use($attachmentPickerDocName)
/** AJAX deletion of attachments. */
onDelete : function(event) {
event.stop();
deleteTool = event.element();
const deleteTool = event.target.closest('.btn');
if (!deleteTool.disabled) {
new XWiki.widgets.ConfirmedAjaxRequest(
deleteTool.readAttribute('href'),
Expand Down Expand Up @@ -680,7 +680,7 @@ $xwiki.jsx.use($attachmentPickerDocName)
/** Update the property with the selected value without reloading the page. */
onSelect : function(event) {
event.stop();
var targetElement = event.element();
const targetElement = event.target.closest('.btn');
var attachmentName = targetElement.up('.gallery_attachmentbox').down('.gallery_attachmenttitle').title;
var imageSource = targetElement.up('.gallery_attachmentbox.gallery_image');
if (imageSource) {
Expand All @@ -695,7 +695,7 @@ $xwiki.jsx.use($attachmentPickerDocName)
if (this.directSave) {
// save via ajax
if (!targetElement.disabled) {
new Ajax.Request(event.element().href, {
new Ajax.Request(targetElement.href, {
onCreate : function() {
targetElement.disabled = true;
targetElement._x_notif = new XWiki.widgets.Notification("$services.localization.render('core.widgets.confirmationBox.notification.inProgress')", 'inprogress');
Expand Down
Loading