ci: workflows: Remove in collaborators check. #90352
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checking for a user in collaborators requires additional permissions not given to our token, so remove the check and rely on exception when attempting to add the user to the PR/issue. To avoid issues with invalid assignments, add PR reviewers one at a time. Signed-off-by: Pete Johanson <[email protected]>
github-actions
bot
requested review from
fabiobaltieri,
kartben,
nashif and
stephanosio
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking for a user in collaborators requires additional permissions not given to our token, so remove the check and rely on exception when attempting to add the user to the PR/issue.
To avoid issues with invalid assignments, add PR reviewers one at a time.
We started using the assigner workflow internally, and needed this small tweak to the script. The GH API will not allow checking for collaborators that come from a team membership unless the token used has additional permissions. By tweaking this to "ask forgiveness, not permission", we can add all the allowed folks and report errors for anyone that's not in the collaborators by individual or team membership.