Skip to content

ci: workflows: Remove in collaborators check. #90352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −9
Open

ci: workflows: Remove in collaborators check. #90352

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions scripts/set_assignees.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,9 +193,6 @@ def process_pr(gh, maintainer_file, number):
gh_user = gh.get_user(collaborator)
if pr.user == gh_user or gh_user in existing_reviewers:
continue
if not gh_repo.has_in_collaborators(gh_user):
log(f"Skip '{collaborator}': not in collaborators")
continue
if gh_user in self_removal:
log(f"Skip '{collaborator}': self removed")
continue
Expand All @@ -208,12 +205,13 @@ def process_pr(gh, maintainer_file, number):
reviewers = reviewers[:reviewer_vacancy]

if reviewers:
try:
log(f"adding reviewers {reviewers}...")
if not args.dry_run:
pr.create_review_request(reviewers=reviewers)
except GithubException:
log("cant add reviewer")
log(f"adding reviewers {reviewers}...")
for r in reviewers:
try:
if not args.dry_run:
pr.create_review_request(reviewers=[r])
except GithubException:
log(f"can't add reviewer {r}")
else:
log("not adding reviewers because the existing reviewer count is greater than or "
"equal to 15")
Expand Down
Loading