logo: Switch app icons to non-"beta" versions #1577
Conversation
|
Looks great on my iPhone! zulip-flutter on the left, zulip-mobile on the right:
|
chrisbobbe
added
the
integration review
There was a problem hiding this comment.
Thanks! Looks great. One further cleanup mentioned below.
The screenshots remind me we should also update the name of the app from "Zulip beta" to just "Zulip". From looking through git grep -i beta, I think that means two files (and three places total):
android/app/src/main/AndroidManifest.xml
8: android:label="Zulip beta"
ios/Runner/Info.plist
10: <string>Zulip beta</string>
18: <string>Zulip beta</string>
| # TODO(#715): use the non-beta version | ||
| src_icon_combined="${root_dir}"/assets/app-icons/zulip-beta-combined.svg | ||
| src_icon_combined="${root_dir}"/assets/app-icons/zulip-combined.svg |
There was a problem hiding this comment.
Let's also delete the beta SVGs from the repo; I don't think we'll have a further use for them once this is merged.
(And if we do, they'll always be there in the Git history.)
|
I'll hold off merging this PR to main, because I may still be making a v0.0.33 to go out as the beta app (in particular to include #1574). I'll definitely use it in preparing the launch build on Monday, though (and might merge it to main shortly before that). I'm also thinking of making a build soon for the main app's beta channel, once an implementation of #1070 is ready, and I'd use this PR in that. |
And remove the beta icon assets. Fixes: zulip#1537
rajveermalviya
force-pushed
the
pr-switch-app-icons
branch
from
a3d0b94 to
2ab189d
Compare
|
Thanks! Revision pushed. |
|
Thanks! Looks good. |
|
Merged (see #1586 (comment)). |
Fixes: #1537