Skip to content

Switch app ID to those of the main app #1586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 15, 2025
Merged

Switch app ID to those of the main app #1586

merged 3 commits into from
Jun 15, 2025

Conversation

rajveermalviya
Copy link
Member

Fixes: #1582

@rajveermalviya rajveermalviya added the maintainer review PR ready for review by Zulip maintainers label Jun 14, 2025
@gnprice
Copy link
Member

gnprice commented Jun 14, 2025

Excellent, thanks! Will look at this today, and use it for preparing a beta with #1070.

@gnprice gnprice mentioned this pull request Jun 14, 2025
Merged
@gnprice
Copy link
Member

gnprice commented Jun 14, 2025

Cool, this all looks good. I'll include it in assembling a branch for switching to be the main app.

@gnprice
Copy link
Member

gnprice commented Jun 15, 2025

OK, I think we are done making releases as the Flutter beta app! So I'll merge this, and before it #1577 and #1585, to main.

If we do find ourselves wanting to make another release as com.zulip.flutter in the future, we can:

  • make a branch atop the current main, i.e. from before I merge these three PRs:
    f8677ac version: Sync version and changelog from v0.0.33 release
  • or make a branch starting from v0.0.33, the last pre-launch release
  • or if we want such a release incorporating significant changes that have happened between now and that future, then make a branch that switches back the app IDs and perhaps app name and app icon.

@gnprice gnprice mentioned this pull request Jun 15, 2025
Merged
@rajveermalviya @gnprice
notif: Use PackageInfo to generate sound resource file URL
a4a96a1
@rajveermalviya @gnprice
android: Switch app ID to that of the main app
e0e51b1 
On Android, switch to using "com.zulipmobile" as the
application ID.

But keep using "com.zulip.flutter" as the JVM package name for
Java/Kotlin code.

Updates: zulip#1582
@rajveermalviya @gnprice
ios: Switch app ID to that of the main app
378e187 
On iOS, switch to using "org.zulip.Zulip" as the
product bundle identifier.

Fixes: zulip#1582
@gnprice gnprice force-pushed the pr-switch-app-ids branch from 73a3d7e to 378e187 Compare June 15, 2025 20:36
@gnprice gnprice merged commit 378e187 into zulip:main Jun 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
maintainer review PR ready for review by Zulip maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch app ID to those of the main app
2 participants
@rajveermalviya @gnprice