New v0.41 version #54
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om the permissions page (metabase#17779)
* expression editor: allow clearing help text with Escape key Move the code to clear help text to "clearSuggestions" method allowing the Escape key to also be used to close the help popup. * expression editor: don't show error on window unfocus * expression editor: allow clicking on "Learn more" Clicking on the "Lean more" link removes the focus from the input box, causing the help dialog to get hidden and become unclickable. Fix by cancelling the mouse down event causing the input box to maintain the focus. Fixes metabase#17548 * add cypress test
OpenAM SAMLResponse contains "\r\n" every 76 characters leading our SAML code to think it's not base64-encoded. Fix by relaxing our valid base64 check to ignore all spaces. Fixes metabase#15567
* let users disable attachments with questions checked * use more declarative assertions in unit tests * use aria-label over testid * translate aria label
…n moving between sidebar views (metabase#17791) * don't set pulse on SharingSidebar mount * remove some old, unused code
…etabase#17761) Merging on behalf of Nemanja * Attempt to fix metabase#17751 * Revert limiting max-width on a parent div * Inherit min-width from a parent div * Unskip repro
* Pass along date formatting * extract and rename some things * Number formatting * Update tests * Improve test validation of svg labels * Clean up tests * Move static-viz interface file to custom file
…y access to a collection (metabase#17722)
* don't show exact seconds for a formatted relative time * add a couple of getRelativeTimeAbbreviated tests
There's more to come WRT the audits, but anton and I agreed to merge something faster and work on that stuff after
When all the necessary data hasn't been fetched you can find yourself in stuck in a loop between the invalid state checks in DataSelector's componentDidUpdate method and the skipSteps method. 1. there seems to always be a single schema (the "Everything Else" schema) available on instantiation 2. the skipSteps method auto-selects this schema when no other schemas exist 3. there's some pre-existing logic to avoid getting in this loop by checking the is_saved_questions property of the database in the selectedSchema. However, for whatever reason this property doesn't exist until AFTER we've fetched some things. The fix is checking a property that is guaranteed to exist, the ID for the "Everything Else" database
…ase#18238) (metabase#18243) * Make webpack output closer to webpack 4 and fix whitelabelling * Fix recently-viewed.cy.spec.js Not sure why it's started failing with this PR, but adding wait for text.
…18253) Co-authored-by: Alexander Lesnenko <[email protected]>
…ersion actually) (18160) (metabase#18230) Cache TTL is defined in the nice new column things as per hour. The actual cache wanted it in seconds. There wasn't a conversion hours->secs before, which was the underlying illusion that gave rise to metabase#18160 - with a properly set cache ttl the cache works fine. But the cache ttl's weren't getting set to proper values because of that lack of unit conversion. So here's the conversion, hours->secs.
…alues found in URL query (metabase#18104) * move logic in dashboard selectors to meta/Dashboard * rmv usage of syncQueryParamsWithURL * add syncQueryParamsWithURL logic to meta/Parameters.js * Fix public questions * fix dashboards * fix query builder * don't normalize when value is empty string * rmv unused setMultipleParameterValues fn * replace selector logic with meta/Dashboard fn * filter out nil fields we need to do more work before we can properly use fields from nested questions when parsing parameter values. * add field to dash parameter so we can correctly type nested native query fields * fix tests * code style tweaks per review
* restyle the Verify button * remove unused components * make the verify button blue Co-authored-by: Maz Ameli <[email protected]>
…et" (metabase#18263) * Fix virtual fields are missing in ParameterValueWidget * fix fk filter parameters Co-authored-by: Alexander Lesnenko <[email protected]>
Co-authored-by: Maz Ameli <[email protected]>
…8237) * Fix Dashboard Subscription email validation (second pass) * Always validate Pulse channels in test endpoint
…g in order clause (metabase#18221) Remove the `driver/format-custom-field-name` implementation for :snowflake, which was causing the problem and appears to be no longer needed anyway Add test for this scenario to `metabase.query-processor-test.expression-aggregations-test`
…tabase#18274) Co-authored-by: Justin McCarthy <[email protected]> Co-authored-by: Pawit Pornkitprasan <[email protected]>
* Add `setupSMTP` helper function * Remove deprecated `setupDummySMTP` helper * Re-use `setupSMTP` helper in tests * Always clear Webmail's inbox after setting up the SMTP Co-authored-by: Nemanja Glumac <[email protected]>
metabase#18270) (metabase#18296) Change implementation of docsUrl to handle RC suffixes for EE versions Change the regex used to test the tag to detect any OSS or EE version, including (possibly) an arbitrary suffix after the major and minor parts, and normalize to the major OSS equivalent version instead. If the suffix, OTOH, is `-SNAPSHOT` (ignoring case), then the doc tag will be `latest`, on the theory that this is as local development build. v0.41.0 => v0.41 v1.41.1 => v0.41 v1.41.2-RC1 => v0.41 v1.42.0-SNAPSHOT => latest Adding unit tests for all cases Update behavior so that -SNAPSHOT suffix points to "latest" Co-authored-by: Jeff Evans <[email protected]>
Co-authored-by: Cam Saul <[email protected]>
Previous PRs for error cards page were laser focused on getting everything to work, as opposed to actually conforming to spec. This one gets it closer to spec, although product wants reloading animations which are not there yet. To wit, - Indicates to end user what the current running state is. Given the many orders of magnitude in DB query run times I think something robust and non-ephemeral is necessary here (looking at some sort of expanded QE model) but Maz suggested expedient method and I took it - No more left nav on the table page - Page heading for table page - Independent scroll-x behavior on the table - Styling for the error section on the table page - Select-all component. Note that the interaction behavior with pagination is fiddly. (but less fiddly now that it's all based on card id's instead of row numbers) - Coalescing default behavior for Our Analytics collection (default collection) and null number of dashboards Rename error name to error content search
* Static viz: respect custom X and Y axis labels * Static viz: allow rendering non-timeseries line charts * Test fixes 🔧
r351574nc3
force-pushed
the
chore/new-version
branch
from
f5be2eb
to
ebf0f45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting the PR, please make sure you do the following
Tests
Run the frontend and Cypress end-to-end tests with
yarn lint && yarn test)If there are changes to the backend codebase, run the backend tests with
lein test && lein lint && ./bin/reflection-linterSign the Contributor License Agreement
(unless it's a tiny documentation change).