New v0.41 version

.babelrc

@@ -1,28 +1,27 @@
 {
   "plugins": [
     "babel-plugin-styled-components",
-    "transform-flow-strip-types",
-    "add-react-displayname",
-    "transform-decorators-legacy",
-    ["transform-builtin-extend", {
-        "globals": ["Error", "Array"]
-    }],
-    "syntax-trailing-function-commas"
+    "@babel/plugin-transform-flow-strip-types",
+    "@babel/plugin-proposal-export-default-from",
+    ["@babel/plugin-proposal-decorators", { "legacy": true }]
   ],
-  "presets": ["es2015", "stage-0", "react"],
+  "presets": ["@babel/preset-env", "@babel/preset-react"],
   "env": {
     "development": {
       "presets": []
     },
     "extract": {
       "plugins": [
-        ["ttag", {
-          "extract": {
-            "output": "locales/metabase-frontend.pot"
-          },
-          "discover": ["t", "jt"],
-          "numberedExpressions": true
-        }]
+        [
+          "ttag",
+          {
+            "extract": {
+              "output": "locales/metabase-frontend.pot"
+            },
+            "discover": ["t", "jt"],
+            "numberedExpressions": true
+          }
+        ]
       ]
     }
   }

.devcontainer/Dockerfile

@@ -2,4 +2,10 @@ FROM mcr.microsoft.com/vscode/devcontainers/java:11
 
 RUN apt-key adv --refresh-keys --keyserver keyserver.ubuntu.com\
   && apt-get update && export DEBIAN_FRONTEND=noninteractive \
-  && apt-get -y install --no-install-recommends leiningen
+  && apt-get -y install --no-install-recommends yarn
+
+RUN curl -fsSL https://deb.nodesource.com/setup_14.x | bash
+RUN apt-get update && apt-get -y install --no-install-recommends nodejs
+
+RUN curl -O https://download.clojure.org/install/linux-install-1.10.3.933.sh \
+  && bash ./linux-install-1.10.3.933.sh

.dir-locals.el

@@ -1,49 +1,78 @@
-((nil . ((indent-tabs-mode . nil)       ; always use spaces for tabs
-         (require-final-newline . t)))  ; add final newline on save
- (js2-mode . ((js2-mode-show-parse-errors . nil)      ; these settings will let flycheck do everything through eslint,
-              (js2-mode-show-strict-warnings . nil))) ; because js2-mode can't handle flowtype
- (clojure-mode . ((eval . (progn
-                            ;; Specify which arg is the docstring for certain macros
-                            ;; (Add more as needed)
-                            (put 'defendpoint 'clojure-doc-string-elt 3)
-                            (put 'defendpoint-async 'clojure-doc-string-elt 3)
-                            (put 'api/defendpoint 'clojure-doc-string-elt 3)
-                            (put 'api/defendpoint-async 'clojure-doc-string-elt 3)
-                            (put 'defsetting 'clojure-doc-string-elt 2)
-                            (put 'setting/defsetting 'clojure-doc-string-elt 2)
-                            (put 's/defn 'clojure-doc-string-elt 2)
-                            (put 'p.types/defprotocol+ 'clojure-doc-string-elt 2)
+((nil
+  ;; always use spaces for tabs
+  (indent-tabs-mode . nil)
+  ;; add final newline on save
+  (require-final-newline . t)
+  ;; prefer keeping source width about ~118, GitHub seems to cut off stuff at either 119 or 120 and it's nicer
+  ;; to look at code in GH when you don't have to scroll back and forth
+  (fill-column . 118)
+  ;; tell find-things-fast to always use this directory as project root regardless of presence of other
+  ;; deps.edn files
+  (ftf-project-finders . (ftf-get-top-git-dir)))
 
-                            ;; Define custom indentation for functions inside metabase.
-                            ;; This list isn't complete; add more forms as we come across them.
-                            (define-clojure-indent
-                              (db/insert-many! 1)
-                              (let-404)
-                              (macros/case 0)
-                              (match 1)
-                              (mbql.match/match 1)
-                              (mt/test-drivers 1)
-                              (mt/query 1)
-                              (mbql.match/match-one 1)
-                              (mbql.match/replace 1)
-                              (mbql.match/replace-in 2)
-                              (impl/test-migrations 2)
-                              (l/matche '(1 (:defn)))
-                              (l/matcha '(1 (:defn)))
-                              (p/defprotocol+ '(1 (:defn)))
-                              (p.types/defprotocol+ '(1 (:defn)))
-                              (p.types/def-abstract-type '(1 (:defn)))
-                              (p.types/deftype+ '(2 nil nil (:defn)))
-                              (p/def-map-type '(2 nil nil (:defn)))
-                              (p.types/defrecord+ '(2 nil nil (:defn)))
-                              (qp.streaming/streaming-response 1)
-                              (prop/for-all 1)
-                              (tools.macro/macrolet '(1 (:defn))))))
-                  (clojure-indent-style . always-align)
-                  ;; if you're using clj-refactor (highly recommended!)
-                  (cljr-favor-prefix-notation . nil)
-                  ;; prefer keeping source width about ~118, GitHub seems to cut off stuff at either 119 or 120 and
-                  ;; it's nicer to look at code in GH when you don't have to scroll back and forth
-                  (fill-column . 118)
-                  (clojure-docstring-fill-column . 118)
-                  (cider-preferred-build-tool . lein))))
+ (js2-mode
+  ;; these settings will let flycheck do everything through eslint,
+  (js2-mode-show-parse-errors . nil)
+  ;; because js2-mode can't handle flowtype
+  (js2-mode-show-strict-warnings . nil))
+
+ (clojure-mode
+  ;; Specify which arg is the docstring for certain macros
+  ;; (Add more as needed)
+  (eval . (put 'defendpoint 'clojure-doc-string-elt 3))
+  (eval . (put 'defendpoint-async 'clojure-doc-string-elt 3))
+  (eval . (put 'define-premium-feature 'clojure-doc-string-elt 2))
+  (eval . (put 'api/defendpoint 'clojure-doc-string-elt 3))
+  (eval . (put 'api/defendpoint-async 'clojure-doc-string-elt 3))
+  (eval . (put 'defsetting 'clojure-doc-string-elt 2))
+  (eval . (put 'setting/defsetting 'clojure-doc-string-elt 2))
+  (eval . (put 's/defn 'clojure-doc-string-elt 2))
+  (eval . (put 'p.types/defprotocol+ 'clojure-doc-string-elt 2))
+  ;; Define custom indentation for functions inside metabase.
+  ;; This list isn't complete; add more forms as we come across them.
+  ;;
+  ;; `put-clojure-indent' is a safe-local-eval-function, so use a bunch of calls to that
+  ;; instead of one call to `define-clojure-indent'
+  (eval . (put-clojure-indent 'c/step 1))
+  (eval . (put-clojure-indent 'db/insert-many! 1))
+  (eval . (put-clojure-indent 'impl/test-migrations 2))
+  (eval . (put-clojure-indent 'let-404 0))
+  (eval . (put-clojure-indent 'macros/case 0))
+  (eval . (put-clojure-indent 'match 1))
+  (eval . (put-clojure-indent 'mbql.match/match 1))
+  (eval . (put-clojure-indent 'mbql.match/match-one 1))
+  (eval . (put-clojure-indent 'mbql.match/replace 1))
+  (eval . (put-clojure-indent 'mbql.match/replace-in 2))
+  (eval . (put-clojure-indent 'mt/dataset 1))
+  (eval . (put-clojure-indent 'mt/query 1))
+  (eval . (put-clojure-indent 'mt/test-drivers 1))
+  (eval . (put-clojure-indent 'prop/for-all 1))
+  (eval . (put-clojure-indent 'qp.streaming/streaming-response 1))
+  ;; these ones have to be done with `define-clojure-indent' for now because of upstream bug
+  ;; https://github.com/clojure-emacs/clojure-mode/issues/600 once that's resolved we should use `put-clojure-indent'
+  ;; instead. Please don't add new entries unless they don't work with `put-clojure-indent'
+  (eval . (define-clojure-indent
+            (l/matcha '(1 (:defn)))
+            (l/matche '(1 (:defn)))
+            (p.types/def-abstract-type '(1 (:defn)))
+            (p.types/defprotocol+ '(1 (:defn)))
+            (p.types/defrecord+ '(2 nil nil (:defn)))
+            (p.types/deftype+ '(2 nil nil (:defn)))
+            (p/def-map-type '(2 nil nil (:defn)))
+            (p/defprotocol+ '(1 (:defn)))
+            (tools.macro/macrolet '(1 ((:defn)) :form))))
+  (cider-clojure-cli-aliases . "dev:drivers:drivers-dev:ee:ee-dev:user")
+  (clojure-indent-style . always-align)
+  (cljr-favor-prefix-notation . nil)
+  (clojure-docstring-fill-column . 118)
+  (cider-preferred-build-tool . clojure-cli))
+
+ ("shared"
+  (clojure-mode
+   (cider-default-cljs-repl . shadow-select)
+   (cider-shadow-default-options . "node-repl")
+   (cider-preferred-build-tool . shadow-cljs)))
+
+ ("bin"
+  (clojure-mode
+   (cider-clojure-cli-aliases . "dev"))))

.dockerignore

@@ -1,12 +1,25 @@
-.babel_cache/*
+.babel_cache
 docs/*
 OSX/*
 target/*
-
-**node_modules
+.circleci
+.cpcache
+.devcontainer
+.github
+.husky
+.lsp
+.shadow-cljs
+.github
+.vscode
+hooks/*
+test/*
+test_config/*
+test_modules/*
+test_resources/*
+node_modules
 **metabase.jar
 
 *.db
 
-.dockerignore
 Dockerfile
+.dockerignore

.eslintrc

@@ -21,13 +21,13 @@
     "react/no-unescaped-entities": 2,
     "react/jsx-no-target-blank": 2,
     "react/jsx-key": 2,
+    "react/forbid-component-props": [2, { "forbid": ["w", "h"] }],
     "prefer-const": [1, { "destructuring": "all" }],
     "no-useless-escape": 0,
     "no-only-tests/no-only-tests": "error",
     "complexity": ["error", { "max": 54 }]
   },
   "globals": {
-    "pending": false,
     "before": true,
     "cy": true,
     "Cypress": true

.github/PULL_REQUEST_TEMPLATE.md

@@ -5,7 +5,6 @@
 ### Tests
 
 - [ ] Run the frontend and Cypress end-to-end tests with `yarn lint && yarn test`)
-- [ ] If there are changes to the backend codebase, run the backend tests with `lein test && lein lint && ./bin/reflection-linter`
-
+- [ ] If there are changes to the backend codebase, run the backend tests with `clojure -X:dev:test`
 - [ ] Sign the [Contributor License Agreement](https://docs.google.com/a/metabase.com/forms/d/1oV38o7b9ONFSwuzwmERRMi9SYrhYeOrkbmNaq9pOJ_E/viewform)
       (unless it's a tiny documentation change).

.github/scripts/README.md

@@ -0,0 +1,3 @@
+# GitHub Action Test Scripts
+
+Scripts related to running integration tests (ex: through GitHub actions)

.github/scripts/run-presto-kerberos-integration-test.sh

@@ -0,0 +1,68 @@
+#! /usr/bin/env bash
+# runs one or more Metabase test(s) against a Kerberized Presto instance
+set -eo pipefail
+
+# Need Java commands on $PATH, which apparently is not yet the case
+export PATH="$PATH:$JAVA_HOME/bin"
+
+# ensure java commmand is available
+which java
+
+# install clojure version needed for Metabase
+curl -O https://download.clojure.org/install/linux-install-1.10.3.933.sh
+chmod +x linux-install-1.10.3.933.sh
+./linux-install-1.10.3.933.sh
+
+RESOURCES_DIR=/app/source/resources
+
+# ensure the expected files are in place, in the resources dir
+if [ ! -f "$RESOURCES_DIR/ssl_keystore.jks" ]; then
+  echo "$RESOURCES_DIR/ssl_keystore.jks does not exist; cannot run test" >&2
+  exit 11
+fi
+
+if [ ! -f "$RESOURCES_DIR/krb5.conf" ]; then
+  echo "$RESOURCES_DIR/krb5.conf does not exist; cannot run test" >&2
+  exit 12
+fi
+
+if [ ! -f "$RESOURCES_DIR/client.keytab" ]; then
+  echo "$RESOURCES_DIR/client.keytab does not exist; cannot run test" >&2
+  exit 13
+fi
+
+# Copy the JDK cacerts file to our resources
+cp $JAVA_HOME/lib/security/cacerts $RESOURCES_DIR/cacerts-with-presto-ca.jks
+
+# Capture the Presto server self signed CA in PEM format
+openssl s_client -showcerts -connect presto-kerberos:7778 </dev/null \
+  | openssl x509 -outform PEM >$RESOURCES_DIR/presto-ssl-root-ca.pem
+
+# Convert the Presto server self signed CA to DER format
+openssl x509 -outform der -in $RESOURCES_DIR/presto-ssl-root-ca.pem  -out $RESOURCES_DIR/presto-ssl-root-ca.der
+
+# Add Presto's self signed CA to the truststore
+keytool -noprompt -import -alias presto-kerberos -keystore $RESOURCES_DIR/cacerts-with-presto-ca.jks \
+        -storepass changeit -file $RESOURCES_DIR/presto-ssl-root-ca.der -trustcacerts
+
+ADDITIONAL_OPTS="SSLKeyStorePath=$RESOURCES_DIR/ssl_keystore.jks&SSLKeyStorePassword=presto\
+&SSLTrustStorePath=$RESOURCES_DIR/cacerts-with-presto-ca.jks&SSLTrustStorePassword=changeit"
+
+# Prepare dependencies
+source "./bin/prep.sh"
+prep_deps
+
+# Set up the environment variables pointing to all of this, and run some tests
+DRIVERS=presto-jdbc \
+MB_ENABLE_PRESTO_JDBC_DRIVER=true \
+MB_PRESTO_JDBC_TEST_HOST=presto-kerberos \
+MB_PRESTO_JDBC_TEST_PORT=7778 \
+MB_PRESTO_JDBC_TEST_SSL=true \
+MB_PRESTO_JDBC_TEST_KERBEROS=true \
+[email protected] \
+[email protected] \
+MB_PRESTO_JDBC_TEST_KERBEROS_REMOTE_SERVICE_NAME=HTTP \
+MB_PRESTO_JDBC_TEST_KERBEROS_KEYTAB_PATH=$RESOURCES_DIR/client.keytab \
+MB_PRESTO_JDBC_TEST_KERBEROS_CONFIG_PATH=$RESOURCES_DIR/krb5.conf \
+MB_PRESTO_JDBC_TEST_ADDITIONAL_OPTIONS=$ADDITIONAL_OPTS \
+clojure -X:dev:test:drivers:drivers-dev :only metabase.driver.presto-jdbc-test