New v0.41 version #54

…om the permissions page (metabase#17779)

* expression editor: allow clearing help text with Escape key Move the code to clear help text to "clearSuggestions" method allowing the Escape key to also be used to close the help popup. * expression editor: don't show error on window unfocus * expression editor: allow clicking on "Learn more" Clicking on the "Lean more" link removes the focus from the input box, causing the help dialog to get hidden and become unclickable. Fix by cancelling the mouse down event causing the input box to maintain the focus. Fixes metabase#17548 * add cypress test

OpenAM SAMLResponse contains "\r\n" every 76 characters leading our SAML code to think it's not base64-encoded. Fix by relaxing our valid base64 check to ignore all spaces. Fixes metabase#15567

…17783) Fixes metabase#16787

* let users disable attachments with questions checked * use more declarative assertions in unit tests * use aria-label over testid * translate aria label

…n moving between sidebar views (metabase#17791) * don't set pulse on SharingSidebar mount * remove some old, unused code

…etabase#17761) Merging on behalf of Nemanja * Attempt to fix metabase#17751 * Revert limiting max-width on a parent div * Inherit min-width from a parent div * Unskip repro

* Pass along date formatting * extract and rename some things * Number formatting * Update tests * Improve test validation of svg labels * Clean up tests * Move static-viz interface file to custom file

…y access to a collection (metabase#17722)

* don't show exact seconds for a formatted relative time * add a couple of getRelativeTimeAbbreviated tests

There's more to come WRT the audits, but anton and I agreed to merge something faster and work on that stuff after

…7782) Fixes metabase#17768

…e#17841)

This was a miserable grind in the old BQ syntax but a happy fun time in the new BQ syntax, basically just turning it on and squashing a bunch of test bugs. One test bug to note especially is that the underscore-transformed set of bird scarcity data for the bird scarcity tests is actually necessary, because BQ will hit you with a complaint about underscores even if you successfully and correctly quote the table names.

* Basic skeleton of front-end dependencies analyzer * Parse enterprise/frontend * Handle good ol' require * For sanity, bail out immediately when encountering a parse errr * Split into commands (currently returning JSON) * Filter dependents from stdin * Track down all dependents, including the indirect/transitive ones * Fix filtering not including the enterprise * Map a directory to its index.js, if it exists * Refactor common functions * Matrix and count dependents

* raw tags * index to start * update toc link * reference link

Add parameter handling for BigDecimal that checks whether the value is in range for BIGNUMERIC or BIGDECIMAL and sets accordingly Updating parameter test to hit both these cases Modifying test code/macros to support a with-table semantic for testing the decimal types via a temp table Writing new test to confirm that all numeric types are synced correctly and can be queried for

Correct typos

… inactive (metabase#17809) * Delete user pulse/alert/dashboard subscription subscriptions when they get archived * Automatically archive Pulses when last subscription is deleted (metabase#17812) * Automatically archive Pulse when its last subscription is deleted * Test fix 🔧 * Fix occasionally-failing rotate-encryption-key!-test * Update pulse_test.clj

* permissions fixes * database block to granular should set no self service * unskip repro

* split dashboard.js into actions + reducers + utils * move test files

Co-authored-by: Nemanja <[email protected]>

* Fix race conditions when loading drivers (part 2) * Test fixes & code cleanup

…n metadata (metabase#17817) * Refactor audit queries to use defmethod instead of weird ^:internal-query-fn metadata * Sort namespaces * Test fix 🔧 * invoke-internal-query -> resolve-internal-query * Fix indentation 🔧 * Minor code cleanup * Revert change to pulse/schedule-frame? * More test fixes 🔧

…base#17781)

… a saved native question (metabase#17872) This was already fixed since 0.40.

…7727) * Add test ID for notebook's action buttons * Add repro for metabase#17712 * Use `Join.clean` in join step's clean callback * Always show a remove icon * Fix referencing an empty dimension * Improve Join's validity check * Don't cleanup incomplete join sections * Fix structured query tests * Don't use MBQL field literals in notebook tests metabase#14824

added the viz-settings parsing middleware to static viz. Column settings are spec'd for regular columns and by name, but we forgot expressions apparently.

…e#17859)

* unskip 17738 repro * move the repro to run in EE

…eriodically (metabase#17165)

* update API docs format * account for other terminal punctuation * clarify api namespace target * update schema test, add-period test * update period test * parens * test endpoint-section * cleanup * Cam edits Co-authored-by: Cam Saul <[email protected]> * trim whitespace * file newlines * Sort namespaces Co-authored-by: Cam Saul <[email protected]> Co-authored-by: Cam Saul <[email protected]>

styled component

* Better with-temp error messages * Undo wacky indentation

* combine sidebar state for various dashboard sidebars * replace hideClickBehaviorSidebar action with closeSidebar * move sidebar name strings to a constants file * add some tests

…etabase#17891) * Add new Settings (placeholders) for the new 0.41.0+ premium features * Code cleanup * Add new features to the `:premium-features` Setting (for FE consumption) * Fix busted ns declarations

The ttag library expect the plural array to be exactly the size as the number of plural forms defined in the header. If we remove empty plural, the array will have the wrong size and the library will crash when the trying to use the non-existent plural. By leaving the empty string there, the ttag library will correctly detect it and use the English version for the missing variant. This does not affect the backend because the backend does not support plurals. Fixes metabase#16323

"include-current" was implemented for "prev" but not for "next". Fixes metabase#17551

The locale list sent to the UI is formatted "pt-BR" but when it is saved to the database, we re-format the locale to "pt_BR", thus on next load, the UI cannot match the saved locale with the locale list. Fix the issue by using normalized value (e.g. "pt_BR") in the available locale list. Fixes metabase#15657, fixes metabase#16654

In addition, mode should be switched to "view" to remove "/notebook" from URL.

… not enabled (metabase#17868) Make use of new visible-if property in plugin definition

…zation (metabase#17860)

Co-authored-by: Jeff Bruemmer <[email protected]>

* fix a few prop errors causing console warnings * fix LastEditInfoLabel test

…tabase#17900) Fixes metabase#17211

Tools are there. Modal is not, along with some styling, but BE has been languishing for months so I wanted to get this in

* Add subscription-allowed-domains allow list Setting * Move email->domain and email-in-domain? util functions to metabase.util * Fix missing require * Test fix 🔧 * Remove useless namespace * Make subscription-allowed-domains a :string Setting rather than :csv

…etabase#17928)

Recognize mode=REPEATED and return :type/Array for it Add test for temp table using an array type column to ensure base type is recongized properly

…deleted (metabase#17887) * invalidate revision entities when questions/dashboards updated/deleted * you can't update a revision * add a cy test to cover revision cache clearing * let's be a little looser with revision text

* Rename dashboard details edit action * Use render props at dashboard edit form * Add enterprise caching plugin * Move dashboard entity forms to own file * Make FormField's margin configurable * Pass custom style to FormField * Use null as a default cacheTTLFormField value * Add tests for DashboardDetailsModal * Add cache_ttl field to DashboardDetailsModal * Add tests for CreateDashboardModal * Test cache_ttl is invisible when creating a dashboard * Remove not used mocks * Add tests for EditQuestionInfoModal * Move question entity forms to own file * Add cache_ttl field to EditQuestionInfoModal * Test cache_ttl is invisible when creating a question * Extract CacheTTLField component * Don't show cache field if caching is disabled * Fix typo * Update cache_ttl field look * Revert "Pass custom style to FormField" This reverts commit 3944ca8ff1dcad478f0f1c3a1973f454447c88c1. * Revert "Make FormField's margin configurable" This reverts commit ca7dc434532038da736012147f6889e6cc01ec11. * Fix CacheTTLField width * Add descriptionPosition prop to FormField * Add DatabaseCacheTTLField * Show cache_ttl field on database form * Use 24h as a default database cache TTL field value * Fallback to database cache_ttl in question form * Remove console.log * Fix request body assertion for CreateDashboardModal * Fix request body assertions for EditQuestionModal * Fix request body assertions for DashboardDetailsModal * Fix cache_ttl not included in `PUT /api/card/:id` * Use simple for for EditQuestionInfoModal * Refactor how unit tests mock caching settings * Add dashboard caching EE test * Add question caching EE test * Add caching e2e test for database add/edit * Remove debug stuff * Add error state to CacheTTLField * Fix DB cache field reverts to default value on 0 * Validate cache_ttl field * Add getQuestionsImplicitCacheTTL helper * Remove redundant tests * Remove not used import * Nomalize `cache_ttl: 0` to null * Fix duplicated card update request * Add QuestionCacheTTLField component * Add test-id to Radio's option names * Use a new cache TTL field for questions * Check setting cache_ttl to null in E2E tests * Style question cache TTL field * Add dashboard ID to query request body * Extend `duration` formatting helper to support hours * Fix default caching duration display * Fix tests * Fix old dashboard edit action title * Fix missing translations * Add prop types to EditQuestionInfoModal * Remove `test.todo` * Simplify `getQuestionsImplicitCacheTTL` * Use `space` style helper * Add `key` prop to `jt` * Move time coverting utils to lib/time * Hide caching field label if just showing the input * Fix unit tests * Fix flacky E2E test * Add hover style for "More options" control * Fix missing translation * Use placeholder for cache inputs * Fix E2E tests to use cache field's placeholder * Feature flag for caching UI

* fix clearing of sidebar state when removing a parameter * add a cy test

…etabase#17947)

* fix reverting dashboard with card deletion `delete-dashboard-card!` expects the :dashboard_id parameter to be defined. * fix frontend issues related to dashboard reverts 1) fix the dashboard not being reloaded to the reverted version after revert 2) fix the history list being reloaded to include the latest change

…etabase#17745)

* Move block permission under advanced permissions flag * fix flag name

…save (metabase#17971) * Fix typo * Add unit tests for `normalizeQuery` * Normalize query clause classes for comparison * Enable the repro test * Rename variable

This should fix metabase#16770.

* Test join's setDimension methods can remove dimensions * Specify temporal-unit for Join unit tests data * Ensure join dimensions' temporal units are the same * Display dimension's temporal unit on Join UI * Add E2E test for join fields temporal units * Select temporal units for join dimensions * Sync parent and join dimensions temporal units * Refactor Join dimension setters * Update subdimension check * Update overwrite check

* EE API endpoint code reorganization * Remove accidental commit * test fixes 🔧 * Remove unused namespace * Remove unused var * Rename metabase-enterprise.audit.* -> metabase-enterprise.audit-app.* * Move the new delete subscriptions endpoint from :advanced-config -> :audit * Prettier

Add separate catch clause for BigQueryException, to `execute-bigquery`, which conveniently includes a property to indicate whether it's retryable, and add that to the ex-data map Add test that confirms a retryable exception is, in fact, retried

* Add reproduction for metabase#17968 * Fix showing incorrect join field table names * Test previous results str

* For sparklines, check that viz type is line this actually goes to fix waterfalls. They would match these requirements but the viz type of waterfall would give results that would dip out of the viewport. Fallback to table rendering * Prevent waterfall rendering as sparkline * please run that cancelled test again, GitHub®

* Fix grid map is not rendered for native questions * add check for map button

…metabase#17956) * Add meta/Dashboard utils for checking mapped dash params * Add tests for meta/Dashboard utils * Add disabled prop to TextWidget * Disable widgets using isDashboardParameterWithoutMapping fn * Update tooltip text Co-authored-by: Maz Ameli <[email protected]> Co-authored-by: Maz Ameli <[email protected]>

* treat empty string parameter in url like it is unset * refactor parameter collection utils

…dpoints (metabase#17740) Co-authored-by: Alexander Polyankin <[email protected]>

…le_field_id (metabase#17958) * When fetching Field also fetch its associated human_readable_field_id * add unit tests

* Add DashboardSubscription and Alert table audit queries * metastore -> premium-features

…d by user (metabase#17981)

…#17896) * Move email->domain and email-in-domain? util functions to metabase.util * Improve the error handling for with-temp a little more. * Extra error context for with-temporary-setting-values * Improve Setting docstring forms validation: handle aliased forms like `i18n/deferred-tru` * Fix missing :require

…ase#17967) When loading dashboard filters, the default value is in `:default` not in `:value`. In the field filter code path, the default is copied to `:value`. Fix the issue by calling the same code for non-field filters too. Fixes metabase#15705

) In `getTableClickedObjectRowData`, we try to get the original row of the data from the rowIndex but because the rowIndex of the pivoted table and the original table does not necessarily match, we get the wrong data. This commit fixes it by storing a mapping between pivoted (row, col) and the original row number and using that to determine which row to use for the data. Fixes metabase#17920

We added cache control fields for dashboard and database and actually use it for cards: presumably EE folks want to audit that stuff. Here is the addition of those fields to the table views.

…e#17987)

… the Dashboard title is updated. (metabase#17955) * added isDirty flag to SET_DASHBOARD_ATTRIBUTES action * added reducer tests for SET_DASHBOARD_ATTRIBUTES with isDirty * lint

…en results are loading (metabase#17954) * Check for existing result set when displaying "Showing [X] rows" instead of the max limit * added cypress test * broke up nested ternary operators in QuestionRowCount

* Formatting return a format string so it can be used over multiple rows. The rules for formatting are quite annoying because there are defaults that are assumed rather than present. IE, if you set a column as currency it doesn't set the number style sometimes and defaults to USD without that being in the settings. In the future would be far preferable to always create a fully fleshed map of defaults rather than inferring them in random places. * appease our doc string supervisor * Include column information for formatting numbers really important for requiring two decimal places by default on doubles and none on integers. Its close to correct ignoring it and using "#,###.##" and this leaves non decimal places on integers and allows only up to two on doubles, but things like 31.10 will format as 31.1 and that is improper * Remove unneeded metabase.test * Update tests with nil column * Get global viz settings in middleware, pass entire to formatting Passing the entire viz settings to the formatting stuff makes the calling code much simpler and the places where we merge global settings, possibly get currency settings, etc, just in one place. We already had the col information there so just use it. * Remove public settings now that we get it from the metadata

…#17982)

metabase#17992) * show meaningful error for waterfall chart of multiple series questions * increase readability

* restore original file name * links

* subscriptions and alerts audit * Add tables * Add tables * Extract to lib * Extract to lib * Add modal * Add modal * Add modal * Fix modals * Fix modals * Add children for displaying modals * Add children for displaying modals * Add children for displaying modals * Add children for displaying modals * Add edit dialogs * Add edit dialogs * Add edit dialogs * Add edit dialogs * Remove deletion * Remove deletion * Add users * Add users * Fix selection issues * Add placeholder * Add placeholder * Add delete button * Fix wrapping issues * F * Small fixes * Add reloading * fixes * cypress specs * fixes * post rebase fixes * rebase fixes * review fixes Co-authored-by: Alexander Polyankin <[email protected]>

metabase#18017)

…metabase#18029)

…lues for boolean fields (metabase#17999) * add template tag fields as dependent metadata for native queries * check for a field_id property added by getValueAndFieldIdPopulatedParametersFromCard * Add NativeQuery dependentMetadata unit test * add test for loadMetadataForQuery

* update api doc gen code * update test

…tely after they are saved (metabase#18033)

* add PK icon * key -> label

Previous implementation was dog slow. This one is faster

* Handle composite PK filters as well as filtering by non unique PK fields * unskip repro * fix * fix * fixes

…but receives an error (metabase#18014)

…8031) * Add a prop to bubble mouse events on SandboxedPortal * Fix drag-n-drop on dashoboard's viz settings modal * Enable repro test

* Fix test's describe block * Mention metabase#16845 repro * Assert native query text is displayed in Audit * Enable the repro test * Fix ad-hoc native query not displayed in Audit correctly * Don't display native query sidebar in read-only mode

* grammar and microcopy tweaks * update cypress test * fix another test * update test again

)

metabase#18049)

metabase#18020) * added check for borderless buttons when setting compact padding * fix my own silly regression * added visual tests for run button regressions * added minWidth to percy snapshot * shoudl have read the docs * Sync VIEWPORT_WIDTH and percy snapshot width

…hile dragging (metabase#18053)

…etabase#18054)

* Enable repro test * Fix personal subcollection in item picker hidden

…s crashes the frontend (metabase#18073) Covers all three scenarios listed in the original issue.

…e wrong row (metabase#18070)

…se#18041)

…#18057) * Add initial e2e test for erroring questions * Add repro for metabase#18050 * Add repro for metabase#18048 * Add test section with that contains broken questions * Improve test and add another scenario

… until you refresh the browser (metabase#18076)

Support query cancellation in new BigQuery driver Remove now unused 60 second timeout Remove a bunch of unneeded code (`with-finished-response`) from the legacy driver Add support for canceling query, which stops pagination of results Add test to confirm pagination stops upon cancellation Add test to confirm that max rows enforcement via middleware prevents unnecessary pages from being fetched

Add test for ordering when nils are present Adding test to ensure that we can handle a column containing nils in an ORDER BY clause Adding `format-name` override for `bigquery-cloud-sdk` to convert dash to underscore in test table names Adding comment showing IDs of each row in the daily-bird-counts.edn file Format last column as int to make Oracle happy Add impls for `presto` and `presto-jdbc` `sorts-nil-first?` as false Make the `sorts-nil-first?` multimethod accept a base type in order to return an answer Vertica, at least, has a different answer for different types; see: https://www.vertica.com/docs/9.2.x/HTML/Content/Authoring/AnalyzingData/Optimizations/NULLPlacementByAnalyticFunctions.htm#2 Updating Vertica implementation to consider the `base-type` as per its documentation Updating all invocations of `sorts-nil-first?` in tests to pass the relevant base type

…metabase#18083) Because we can't fully implement all the driver deprecation UX in time for release 41, we will adjust the language to allow flexibility for when to actually start the deprecation clock

…base#18023) `query->native` works by having `nativef` throws an exception which causes `mbql->native` to set native query to `nil` which then cause the rest of the execution to be skipped. However, because the existing code skips overriding the native query for queries already native, the execution is not skipped. This causes bad performance for nested native question because `query->native` is called for the sub-query which causes the sub-query to be executed on its own, potentially without any limit or filtering.

…ries (metabase#17855) See metabase#15882 (comment) for detailed explanation. Fixes metabase#15882

This is a combination of 2 issues: 1) pt got renamed to pt_BR in x.39.x but the old "pt" value may still be stored in the database 2) when making a release, an unclean build directory may be used containing old "pt" resource which gets leaked into the release build 1) is fixed by adding a function to treat "pt" as "pt_BR" to support users who were on "pt" since pre-x.39. (This is done by finding the closest fallback locale) 2) is fixed by emptying the folder before generating locales so any old locales are deleted. Fixes metabase#16690

…metabase#18088) This reverts commit 46c76c9.

…ified badge (metabase#18080)

…tick quoting (metabase#17979) Fix BigQuery Percentile and Median expressions not using correct backtick quoting Ensure the identifier components are quoted by reifying `ToSql` for the `APPROX_QUANTILES` expression Add test to ensure query is created properly Mark `:percentile-aggregations` as being supported in the new driver

Details page for tools to fix broken questions. Also the PR ran long enough that nemanja found some bugs in the details page. Does not include any loading overlay or anything to indicate that reloads are happening, which is for 41.1 I guess

* Do not change display on drill down to questions * unskip repro * include displayIsLocked explicitly otherwise it breaks almost the entire app

…etabase#18103) This reverts commit f94510a.

Cache controls all landed but is lacking in the audit capacity wanted for in the notion doc. This PR adds that audit capability and by the by changes the ViewLog model in order to be able to deliver on the question of whether ViewLogs were cache hits or not.

from maz in slack: Should not remove verification: - Moving to another collection - Pinning/unpinning - Adding/removing an alert on the question - Turning sharing on the question on/off Should remove verification: - Editing the query - Editing the visualization or viz settings - Editing the title or description This really just identifies when not to remove verification, otherwise does remove verification. Alerts are not related to questions through the api so no worries there. Everything else is just excluding attributes from the diff calculation. In tests, went perhaps a bit haywire with the macrolet, allowing to define macros inline rather than farther away from the call site. Used twice: - once to optionally add in moderation review into the with-temp. This macro is handy to ensure we always have a fresh state of card and don't have leftover changes or verifications. Has to be a macro since i want to dynamically change whether there are verifications in the with-temp* vector binding - a way to more easily reduce repetition when asserting something is verified, do an action, and assert it is still verified

- `TEXT` in Redshift is equivalent to `VARCHAR(256)`, use `VARCHAR(1024)` instead - Unskip all tests skipped on Redshift due to sample dataset issue - Add explicit `:order-by` to `join-source-queries-with-joins-test` to make it pass in Redshift as Redshift does not preserve order after join (like a lot of other distributed query engines) - Add `VACUUM` and `ANALYZE` call after INSERT to improve performance

Overall purpose of PR is to add row drill-ins to the tools to fix broken questions, so you can take a look-see into what the broken questions are. A tiny nit thing wasn't caught by CI and broke master. This was because there's a CI cache. I can confirm that this didn't hit the CI cache and the other thing that broke isn't breaking anymore

* Minor async require cleanup * Sort namespaces

* Set the timeout to 2s because of Mongo

)

…tabase#18109) Check feature flag on backend /graph PUT API for block permission Check for the `:advanced-permissions` flag in `update-db-permissions!`, when a `:schemas` `:block` entry is present in the graph Set feature flag in tests when using API Add new test to ensure failure in the case that feature flag is missing

…etabase#18142)

Co-authored-by: Alexander Lesnenko <[email protected]>

metabase#18136) (metabase#18138) (metabase#18164) There is a problem when there are no card ids for a userland query (so not all userland queries are non-adhoc queries: they can be adhoc), where viewlog needs a card id so it chokes. Just adds a check so it doesn't even try to emit a viewlog, since the auditing is for non-adhoc queries only. Co-authored-by: Howon Lee <[email protected]>

…ames (metabase#18055) (metabase#18177) Add `escape-alias` multimethod to `sql.qp` to handle translating an alias (whether for a field or expression) into something supported by the driver in quesion Add default impl that is essentially identity Marking `sql.qp/field->alias` as deprecated, and changing its default implementation to invoke the new `sql.qp/escape-alias` on the field's `:name` (with the intention of removing it in a future release, since individual driver won't need to override this, so much as they'll need to override `escape-alias` itself). Override `sql.qp/escape-alias` method for both BigQuery drivers to run through the same `->valid-field-identifier` function already defined for this purpose Add test for a custom expression with weird characters Co-authored-by: Jeff Evans <[email protected]>

Closes metabase#18168.

…18185)

* Create `postgres-12` snapshot * Use `postgres-12` snapshot in tests * Relocate postgres `add` spec * Relocate postgres `sandboxes` spec * Relocate postgres `native` spec This actually didn't have anything to do with the native questions. We simply used native editor because it was easier to reproduce the issue. * Relocate postgres `permissions` spec * Relocate postgres `query` spec * Relocate postgres `custom-column` spec * Remove postgres from `metabase-db`

- a56b640 broke Percy workflow on master and introduced a major inconvenience for developers who wish to run Cypress locally. In both cases, it's required to have all supported QA DB docker images running at all times. Otherwise, the Cypress snapshot creation phase breaks. This PR: - uses the existing ENV var to conditionally skip qa db snapshots - this doesn't affect CircleCI workflow - it merely makes life easier for developers running Cypress locally and for a Percy workflow that runs on GitHub Actions (where we still don't have QA docker images available) Co-authored-by: Nemanja Glumac <[email protected]>

* Create `mongo-4` snapshot * Use `mongo-4` snapshot in tests * Restore and authenticate * Relocate mongo `line` spec * Relocate mongo `native` spec * Relocate mongo `add` spec * Extract repro for metabase#13097 * Relocate mongo `query` spec * Remove mongo from `metabase-db` Co-authored-by: Nemanja Glumac <[email protected]>

…ings normalization" (metabase#18200) Co-authored-by: Noah Moss <[email protected]>

* Show hidden tables permissions, load tables only when needed * fix padding * remove loader div wrapper * remove redundant wrappers Co-authored-by: Alexander Lesnenko <[email protected]>

…8151) (metabase#18212)

…18218)

…se#18215) Co-authored-by: Alexander Lesnenko <[email protected]>

…base#18123)

When all the necessary data hasn't been fetched you can find yourself in stuck in a loop between the invalid state checks in DataSelector's componentDidUpdate method and the skipSteps method. 1. there seems to always be a single schema (the "Everything Else" schema) available on instantiation 2. the skipSteps method auto-selects this schema when no other schemas exist 3. there's some pre-existing logic to avoid getting in this loop by checking the is_saved_questions property of the database in the selectedSchema. However, for whatever reason this property doesn't exist until AFTER we've fetched some things. The fix is checking a property that is guaranteed to exist, the ID for the "Everything Else" database

…ase#18238) (metabase#18243) * Make webpack output closer to webpack 4 and fix whitelabelling * Fix recently-viewed.cy.spec.js Not sure why it's started failing with this PR, but adding wait for text.

…8227) (metabase#18244)

…18253) Co-authored-by: Alexander Lesnenko <[email protected]>

…ersion actually) (18160) (metabase#18230) Cache TTL is defined in the nice new column things as per hour. The actual cache wanted it in seconds. There wasn't a conversion hours->secs before, which was the underlying illusion that gave rise to metabase#18160 - with a properly set cache ttl the cache works fine. But the cache ttl's weren't getting set to proper values because of that lack of unit conversion. So here's the conversion, hours->secs.

…alues found in URL query (metabase#18104) * move logic in dashboard selectors to meta/Dashboard * rmv usage of syncQueryParamsWithURL * add syncQueryParamsWithURL logic to meta/Parameters.js * Fix public questions * fix dashboards * fix query builder * don't normalize when value is empty string * rmv unused setMultipleParameterValues fn * replace selector logic with meta/Dashboard fn * filter out nil fields we need to do more work before we can properly use fields from nested questions when parsing parameter values. * add field to dash parameter so we can correctly type nested native query fields * fix tests * code style tweaks per review

…n't set (metabase#18257) (metabase#18261)

* restyle the Verify button * remove unused components * make the verify button blue Co-authored-by: Maz Ameli <[email protected]>

…et" (metabase#18263) * Fix virtual fields are missing in ParameterValueWidget * fix fk filter parameters Co-authored-by: Alexander Lesnenko <[email protected]>

Co-authored-by: Maz Ameli <[email protected]>

…8237) * Fix Dashboard Subscription email validation (second pass) * Always validate Pulse channels in test endpoint

…g in order clause (metabase#18221) Remove the `driver/format-custom-field-name` implementation for :snowflake, which was causing the problem and appears to be no longer needed anyway Add test for this scenario to `metabase.query-processor-test.expression-aggregations-test`

…tabase#18274) Co-authored-by: Justin McCarthy <[email protected]> Co-authored-by: Pawit Pornkitprasan <[email protected]>

…metabase#18283)

* Add `setupSMTP` helper function * Remove deprecated `setupDummySMTP` helper * Re-use `setupSMTP` helper in tests * Always clear Webmail's inbox after setting up the SMTP Co-authored-by: Nemanja Glumac <[email protected]>

…etabase#18288)

…etabase#18225) (metabase#18287)

metabase#18270) (metabase#18296) Change implementation of docsUrl to handle RC suffixes for EE versions Change the regex used to test the tag to detect any OSS or EE version, including (possibly) an arbitrary suffix after the major and minor parts, and normalize to the major OSS equivalent version instead. If the suffix, OTOH, is `-SNAPSHOT` (ignoring case), then the doc tag will be `latest`, on the theory that this is as local development build. v0.41.0 => v0.41 v1.41.1 => v0.41 v1.41.2-RC1 => v0.41 v1.42.0-SNAPSHOT => latest Adding unit tests for all cases Update behavior so that -SNAPSHOT suffix points to "latest" Co-authored-by: Jeff Evans <[email protected]>

Co-authored-by: Cam Saul <[email protected]>

Previous PRs for error cards page were laser focused on getting everything to work, as opposed to actually conforming to spec. This one gets it closer to spec, although product wants reloading animations which are not there yet. To wit, - Indicates to end user what the current running state is. Given the many orders of magnitude in DB query run times I think something robust and non-ephemeral is necessary here (looking at some sort of expanded QE model) but Maz suggested expedient method and I took it - No more left nav on the table page - Page heading for table page - Independent scroll-x behavior on the table - Styling for the error section on the table page - Select-all component. Note that the interaction behavior with pagination is fiddly. (but less fiddly now that it's all based on card id's instead of row numbers) - Coalescing default behavior for Our Analytics collection (default collection) and null number of dashboards Rename error name to error content search

* Static viz: respect custom X and Y axis labels * Static viz: allow rendering non-timeseries line charts * Test fixes 🔧

Commits on Dec 6, 2023

New metabase version

r351574nc3 committed Dec 6, 2023

Configuration menu

View commit details

Copy full SHA for ebf0f45

Browse repository at this point

Copy the full SHA

ebf0f45 View commit details

Browse the repository at this point in the history

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New v0.41 version #54

New v0.41 version #54

Commits on Sep 7, 2021

Commits on Sep 8, 2021

Commits on Sep 9, 2021

Commits on Sep 10, 2021

Commits on Sep 11, 2021

Commits on Sep 13, 2021

Commits on Sep 14, 2021

Commits on Sep 15, 2021

Commits on Sep 16, 2021

Commits on Sep 17, 2021

Commits on Sep 20, 2021

Commits on Sep 21, 2021

Commits on Sep 22, 2021

Commits on Sep 23, 2021

Commits on Sep 24, 2021

Commits on Sep 27, 2021

Commits on Sep 28, 2021

Commits on Sep 29, 2021

Commits on Sep 30, 2021

Commits on Oct 1, 2021

Commits on Oct 4, 2021

Commits on Oct 5, 2021

Commits on Oct 6, 2021

Commits on Dec 6, 2023

New v0.41 version #54

Are you sure you want to change the base?

New v0.41 version #54

Commits on Sep 7, 2021

Commits on Sep 8, 2021

Commits on Sep 9, 2021

Commits on Sep 10, 2021

Commits on Sep 11, 2021

Commits on Sep 13, 2021

Commits on Sep 14, 2021

Commits on Sep 15, 2021

Commits on Sep 16, 2021

Commits on Sep 17, 2021

Commits on Sep 20, 2021

Commits on Sep 21, 2021

Commits on Sep 22, 2021

Commits on Sep 23, 2021

Commits on Sep 24, 2021

Commits on Sep 27, 2021

Commits on Sep 28, 2021

Commits on Sep 29, 2021

Commits on Sep 30, 2021

Commits on Oct 1, 2021

Commits on Oct 4, 2021

Commits on Oct 5, 2021

Commits on Oct 6, 2021

Commits on Dec 6, 2023