Skip to content

Commit 91e4c91

Browse files
committed
Add some reserved names in tests
1 parent ba62519 commit 91e4c91

File tree

2 files changed

+30
-2
lines changed

2 files changed

+30
-2
lines changed

v-next/core/test/internal/global-options.ts

+15-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import assert from "node:assert/strict";
2-
import { describe, it } from "node:test";
2+
import { after, before, describe, it } from "node:test";
33

44
import { HardhatError } from "@ignored/hardhat-vnext-errors";
55

@@ -13,6 +13,20 @@ import { RESERVED_PARAMETER_NAMES } from "../../src/internal/parameters.js";
1313
import { createTestEnvManager } from "../utils.js";
1414

1515
describe("Global Options", () => {
16+
before(() => {
17+
// Make sure we have some reserved names
18+
RESERVED_PARAMETER_NAMES.add("testName1");
19+
RESERVED_PARAMETER_NAMES.add("testName2");
20+
RESERVED_PARAMETER_NAMES.add("testName3");
21+
});
22+
23+
after(() => {
24+
// Delete the test reserved names
25+
RESERVED_PARAMETER_NAMES.delete("testName1");
26+
RESERVED_PARAMETER_NAMES.delete("testName2");
27+
RESERVED_PARAMETER_NAMES.delete("testName3");
28+
});
29+
1630
describe("buildGlobalOptionsMap", () => {
1731
it("should build an empty map of global options if no plugins are provided", () => {
1832
const globalOptionsMap = buildGlobalOptionsMap([]);

v-next/core/test/internal/tasks/builders.ts

+15-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import assert from "node:assert/strict";
2-
import { describe, it } from "node:test";
2+
import { after, before, describe, it } from "node:test";
33

44
import { HardhatError } from "@ignored/hardhat-vnext-errors";
55

@@ -13,6 +13,20 @@ import { ParameterType } from "../../../src/types/common.js";
1313
import { TaskDefinitionType } from "../../../src/types/tasks.js";
1414

1515
describe("Task builders", () => {
16+
before(() => {
17+
// Make sure we have some reserved names
18+
RESERVED_PARAMETER_NAMES.add("testName1");
19+
RESERVED_PARAMETER_NAMES.add("testName2");
20+
RESERVED_PARAMETER_NAMES.add("testName3");
21+
});
22+
23+
after(() => {
24+
// Delete the test reserved names
25+
RESERVED_PARAMETER_NAMES.delete("testName1");
26+
RESERVED_PARAMETER_NAMES.delete("testName2");
27+
RESERVED_PARAMETER_NAMES.delete("testName3");
28+
});
29+
1630
describe("EmptyTaskDefinitionBuilderImplementation", () => {
1731
it("should create an empty task definition builder", () => {
1832
const builder = new EmptyTaskDefinitionBuilderImplementation("task-id");

0 commit comments

Comments
 (0)